[Keyboard] IDOBAO ID67 code touch-ups and include factory keymap #17231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup of IDOBAO keyboards - ID67
This PR cleans up some issue with the ID67 keyboard range and includes:
rules.mk
andconfig.h
to use data driven configuration from a revisedinfo.json
.0x0067
to0x0267
, as the latter causes issues with legacy users leveraging VIA. New V2 boards could also not be added to VIA due to this version conflict.SPDX-License-Identifier
180
(70%)id67.c
file:g_led_config
varVIA_QMK_RGBLIGHT_ENABLE
(not needed since QMK 0.17)default
andvia
keymapsidobao
keymap, that represents the source code of the factory installed firmwarepost_rules.mk
file to allow compile of firmware without the underglow LED active for boards that do not have transparent undersides. This eliminates heat and needless power consumption for variants such as the "Bestype".Types of Changes
Issues Fixed or Closed by This PR
Checklist