Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] IDOBAO ID67 code touch-ups and include factory keymap #17231

Merged
merged 9 commits into from
Jul 2, 2022

Conversation

silvinor
Copy link
Contributor

@silvinor silvinor commented May 29, 2022

Description

Cleanup of IDOBAO keyboards - ID67

This PR cleans up some issue with the ID67 keyboard range and includes:

  • Clean rules.mk and config.h to use data driven configuration from a revised info.json.
  • .. including moving the USB Device ID from 0x0067 to 0x0267, as the latter causes issues with legacy users leveraging VIA. New V2 boards could also not be added to VIA due to this version conflict.
  • Simpler file licence headers using SPDX-License-Identifier
  • Clean-up of RGB Matrix animations
  • Change RGB max brightness to 180 (70%)
  • id67.c file:
    • Clean-up of RGB Matrix g_led_config var
    • Text graphical map of LED addresses
    • Removal of non-functional Caps-Lock LED code
  • Keymaps:
    • Removal of VIA_QMK_RGBLIGHT_ENABLE (not needed since QMK 0.17)
    • Text graphical map of keys in default and via keymaps
    • Addition of idobao keymap, that represents the source code of the factory installed firmware
  • Addition of post_rules.mk file to allow compile of firmware without the underglow LED active for boards that do not have transparent undersides. This eliminates heat and needless power consumption for variants such as the "Bestype".

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 29, 2022
@drashna drashna requested a review from a team May 29, 2022 22:12
@tzarc tzarc merged commit 882eadd into qmk:develop Jul 2, 2022
@silvinor silvinor deleted the vr-id67-dev-touch branch July 3, 2022 01:58
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants