Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Mouse key kinetic mode fix #17176

Merged
merged 2 commits into from
Jun 19, 2022
Merged

[Core] Mouse key kinetic mode fix #17176

merged 2 commits into from
Jun 19, 2022

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented May 21, 2022 •
edited
Loading

Description

Iterating the mouse key kinetic mode fix from #16951 with functional mouse wheel and slightly faster and usable defaults.

Types of Changes

  • Core
  • Bugfix
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@filterpaper filterpaper changed the title [Code] Mouse key kinetic mode fix [Core] Mouse key kinetic mode fix May 21, 2022
@drashna
Copy link
Member

drashna commented May 21, 2022

Lint is upset. File needs a format pass.

drashna
drashna requested changes May 21, 2022
View reviewed changes
quantum/mousekey.c Outdated Show resolved Hide resolved
quantum/mousekey.c Outdated Show resolved Hide resolved
@filterpaper @drashna
Keep linter happy
a430f6d 
Co-authored-by: Drashna Jaelre <[email protected]>
@filterpaper
Copy link
Contributor Author

Lint is upset. File needs a format pass.

Can't have nice spacing with linter around.

@filterpaper filterpaper requested a review from drashna May 21, 2022 23:24
@drashna drashna requested a review from a team May 23, 2022 05:05
@draffensperger
Copy link

draffensperger commented Jun 19, 2022 •
edited
Loading

I tried this branch out on my Moonlander and it works well for me! I like the kinetic mouse keys algorithm - helps with both slow and fast movements better
(but fixing the wheel scroll was crucial for me). Any chance this could get final review and merged in?

@filterpaper
Copy link
Contributor Author

This PR is will be merged into develop branch. Barring bugs, it should be in master by August 27, 2022.

@drashna drashna merged commit c725b6b into qmk:develop Jun 19, 2022
@filterpaper filterpaper deleted the mousekey-kinetic-fix branch June 20, 2022 00:49
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@filterpaper @drashna @zykrah
[Core] Mouse key kinetic mode fix (qmk#17176)
ed105e8 
Co-authored-by: Drashna Jaelre <[email protected]>
@drashna drashna mentioned this pull request Aug 27, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filterpaper @drashna @draffensperger @fauxpark