Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] MOUSEKEY_BASE_SPEED has no effect in Kinetic mode #13711

Closed
3 tasks
y-usuzumi opened this issue Jul 25, 2021 · 2 comments
Closed
3 tasks

[Bug] MOUSEKEY_BASE_SPEED has no effect in Kinetic mode #13711

y-usuzumi opened this issue Jul 25, 2021 · 2 comments
Assignees

Comments

@y-usuzumi
Copy link

y-usuzumi commented Jul 25, 2021

Describe the Bug

In Kinetic mode, as per the document, MOUSEKEY_BASE_SPEED controls the maximum mouse speed. However, no matter which value I give it, the maximum mouse speed seems to be the same. However, if I increase MOUSEKEY_MOVE_DELTA, the maximum mouse speed increases.

My config:

#define MK_KINETIC_SPEED
#define MOUSEKEY_INTERVAL 8
#define MOUSEKEY_MOVE_DELTA 4
#define MOUSEKEY_INITIAL_SPEED 1
#define MOUSEKEY_BASE_SPEED 100

My goal is to increase the duration from pressing a mouse cursor button to reach its maximum speed.

Thanks!

System Information

  • Keyboard: Moonlander Mark I
  • Operating system: Arch Linux
  • AVR GCC version: 11.1.0
  • ARM GCC version: 11.1.0
  • QMK Firmware version: 0.13.26
  • Any keyboard related software installed?
    • AutoHotKey
    • Karabiner
    • Other:
@Lilalas
Copy link

Lilalas commented Aug 19, 2021

@drashna Do you have any idea what’s going on here? I think I am affected by the same bug on my Planck EZ. I set my base speed to 0 for testing purposes, and my maximum speed is still extremely fast.

Maybe it would be wise to take @liyang’s reimplementation instead of trying to fix the current code. The code looks cleaner and the documentation is so much more descriptive.

Edit: I think this issue might actually be a duplicate of #12082.


@y-usuzumi If all you want to archive is to increase the duration for reaching maximum speed, maybe setting MOUSEKEY_MOVE_DELTA to a lower value could help you. I don’t see why you would need to change MOUSEKEY_BASE_SPEED to archive this.


As a workaround for limiting the maximal speed, one can simply decrease the value of MOUSEKEY_MOVE_MAX instead of MOUSEKEY_BASE_SPEED. For example, add the following to your config.h:

#define MOUSEKEY_MOVE_MAX 20

@kuanyinglu
Copy link

I think the kinetic mode is still not working on v0.14.30. In mousekey.c, the ifndef MK_COMBINED clause takes precedence over ifdef MK_KINETIC_SPEED. However, MOUSEKEY_MOVE_DELTA is still used by the other mode, which is why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants