Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add damapad #16443

Merged
merged 8 commits into from
Mar 13, 2022
Merged

Add damapad #16443

merged 8 commits into from
Mar 13, 2022

Conversation

matthewdias
Copy link
Contributor

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 24, 2022
@matthewdias matthewdias mentioned this pull request Feb 24, 2022
6 tasks
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've accidentally added this board twice?

keyboards/bolsa/damapad/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team February 24, 2022 18:36
keyboards/bolsa/damapad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/bolsa/damapad/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/bolsa/damapad/damapad.c Outdated Show resolved Hide resolved
@@ -0,0 +1,63 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have this in multiple folders?

@drashna drashna requested a review from a team February 27, 2022 02:19
@matthewdias
Copy link
Contributor Author

Forgot to commit the deletions when i moved the folder. thanks for the reviews!

@matthewdias matthewdias requested review from drashna and fauxpark and removed request for a team February 27, 2022 20:08
@drashna drashna requested a review from a team February 27, 2022 22:59
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an info.json.

keyboards/bolsa/damapad/info.json Outdated Show resolved Hide resolved
keyboards/bolsa/damapad/config.h Outdated Show resolved Hide resolved
@drashna drashna merged commit dccb571 into qmk:master Mar 13, 2022
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Mar 14, 2022
* qmk/develop: (696 commits)
  Sentence correction (qmk#16650)
  [Keyboard] Add via keymap to AL1 (qmk#16499)
  Rename TICK to TICK_EVENT to prevent naming conflicts (qmk#16649)
  [Keyboard] Add BAMFK-1 (qmk#16409)
  Disable RGB matrix pixel animations for some boards (qmk#16643)
  keebio/iris: Add ifdefs to encoder callbacks (qmk#16642)
  bolsa/damapad - Fix missing layout macro (qmk#16639)
  Mousekeys fix (qmk#16640)
  Fix oneshot toggle logic (qmk#16630)
  Fix 40percentclub USB descriptors (qmk#16638)
  [Core] Move `has_mouse_report_changed` function to `report.c`  (qmk#16543)
  ISP flashing guide: add instructions for flashing STM32duino bootloader (qmk#16568)
  Move keyboard USB IDs and strings to data driven: 0-9 (qmk#16481)
  USB-USB converter cleanup (qmk#16618)
  [Keyboard] Add "Uno" rev2 (qmk#14071)
  [Keyboard] Add support for Jels60 (qmk#16605)
  helix:edvorakjp keymap change to use split_common (qmk#16532)
  [Keymap] Update personal crkbd keymap (qmk#16624)
  [Keyboard] add missing endif in glitch keyboard (qmk#16629)
  [Keyboard] Add damapad (qmk#16443)
  ...
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Mar 18, 2022
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants