Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BAMFK-1 #16409

Merged
merged 10 commits into from
Mar 14, 2022
Merged

Add BAMFK-1 #16409

merged 10 commits into from
Mar 14, 2022

Conversation

nooges
Copy link
Member

@nooges nooges commented Feb 20, 2022

Description

Add BAMFK-1 keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 20, 2022
drashna
drashna reviewed Feb 21, 2022
View reviewed changes
keyboards/keebio/bamfk1/bamfk1.c Outdated Show resolved Hide resolved
keyboards/keebio/bamfk1/config.h Outdated Show resolved Hide resolved
keyboards/keebio/bamfk1/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@nooges nooges marked this pull request as draft February 21, 2022 14:49
@nooges nooges marked this pull request as ready for review February 22, 2022 23:56
@nooges nooges requested a review from a team March 10, 2022 16:39
fauxpark
fauxpark requested changes Mar 10, 2022
View reviewed changes
keyboards/keebio/bamfk1/rules.mk Outdated Show resolved Hide resolved
keyboards/keebio/bamfk1/config.h Outdated Show resolved Hide resolved
@nooges nooges requested a review from fauxpark March 14, 2022 14:05
@drashna drashna merged commit a12d58c into qmk:master Mar 14, 2022
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Mar 14, 2022
Merge remote-tracking branch 'qmk/develop' into develop
8e42d0f 
* qmk/develop: (696 commits)
  Sentence correction (qmk#16650)
  [Keyboard] Add via keymap to AL1 (qmk#16499)
  Rename TICK to TICK_EVENT to prevent naming conflicts (qmk#16649)
  [Keyboard] Add BAMFK-1 (qmk#16409)
  Disable RGB matrix pixel animations for some boards (qmk#16643)
  keebio/iris: Add ifdefs to encoder callbacks (qmk#16642)
  bolsa/damapad - Fix missing layout macro (qmk#16639)
  Mousekeys fix (qmk#16640)
  Fix oneshot toggle logic (qmk#16630)
  Fix 40percentclub USB descriptors (qmk#16638)
  [Core] Move `has_mouse_report_changed` function to `report.c`  (qmk#16543)
  ISP flashing guide: add instructions for flashing STM32duino bootloader (qmk#16568)
  Move keyboard USB IDs and strings to data driven: 0-9 (qmk#16481)
  USB-USB converter cleanup (qmk#16618)
  [Keyboard] Add "Uno" rev2 (qmk#14071)
  [Keyboard] Add support for Jels60 (qmk#16605)
  helix:edvorakjp keymap change to use split_common (qmk#16532)
  [Keymap] Update personal crkbd keymap (qmk#16624)
  [Keyboard] add missing endif in glitch keyboard (qmk#16629)
  [Keyboard] Add damapad (qmk#16443)
  ...
@nooges nooges deleted the bamfk-1 branch March 15, 2022 03:15
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Mar 18, 2022
@nooges @fauxpark @tacahiroy
[Keyboard] Add BAMFK-1 (qmk#16409)
ac778be 
Co-authored-by: Ryan <[email protected]>
@nooges nooges mentioned this pull request Mar 21, 2022
Merged
6 tasks
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@nooges @fauxpark @zykrah
[Keyboard] Add BAMFK-1 (qmk#16409)
3e18a30 
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nooges @drashna @fauxpark