Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BDN9 keymap #15924

Merged
merged 2 commits into from
Feb 21, 2022
Merged

BDN9 keymap #15924

merged 2 commits into from
Feb 21, 2022

Conversation

lickel
Copy link
Contributor

@lickel lickel commented Jan 18, 2022 •
edited
Loading

Description

This is a BDN9 keymap that toggles between two core layers. It has VIA enabled by default.
It uses the RGB matrix to signify which layer is currently active.

It was originally cherry-picked from #15922

It depends upon #15923

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr
Copy link
Member

zvecr commented Jan 18, 2022

Core changes need to be submitted as its own PR.

@lickel
Copy link
Contributor Author

lickel commented Jan 18, 2022

Yup. This is a draft, waiting for the core PR to merge

@zvecr zvecr added the awaiting_pr Relies on another PR to be merged first label Jan 18, 2022
@lickel lickel marked this pull request as ready for review February 5, 2022 03:14
@lickel
Copy link
Contributor Author

lickel commented Feb 5, 2022

@zvecr the "awaiting_pr" tag is no longer accurate. I am not able to remove it myself.

@drashna drashna removed the awaiting_pr Relies on another PR to be merged first label Feb 6, 2022
@lickel lickel requested a review from drashna February 6, 2022 22:58
@drashna drashna requested a review from a team February 12, 2022 04:21
@lickel
Copy link
Contributor Author

lickel commented Feb 21, 2022

@drashna or @fauxpark anything else needed to merge this?

@drashna drashna merged commit a5901a6 into qmk:develop Feb 21, 2022
@drashna
Copy link
Member

drashna commented Feb 21, 2022

Thanks!

1 similar comment
@lickel
Copy link
Contributor Author

lickel commented Feb 21, 2022

Thanks!

@lickel lickel deleted the bdn9-keymap-dev branch February 21, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lickel @zvecr @drashna @fauxpark