Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDN9 keymap #15922

Closed
wants to merge 1 commit into from
Closed

BDN9 keymap #15922

wants to merge 1 commit into from

Conversation

lickel
Copy link
Contributor

@lickel lickel commented Jan 18, 2022

Description

This is a BDN9 keymap that toggles between two core layers. It has VIA enabled by default.

I have included a trivial rgb_matrix_reload_from_eeprom() implementation drawing heavily from the equivalent rgblight_reload_from_eeprom().

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@lickel
Copy link
Contributor Author

lickel commented Jan 18, 2022

Please let me know if I need to extract out rgb_matrix_reload_from_eeprom() into a separate PR

@daskygit
Copy link
Member

Please let me know if I need to extract out rgb_matrix_reload_from_eeprom() into a separate PR

Yes it will definitely need pulling out into a separate PR. It will also need to target develop as with any core change.

@lickel lickel closed this Jan 18, 2022
This was referenced Jan 18, 2022
@lickel lickel deleted the bdn9-keymap branch January 18, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants