Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sol 3 Keyboard from RGBKB #15687

Merged
merged 10 commits into from
Jan 22, 2022
Merged

Sol 3 Keyboard from RGBKB #15687

merged 10 commits into from
Jan 22, 2022

Conversation

XScorpion2
Copy link
Contributor

@XScorpion2 XScorpion2 commented Dec 31, 2021 •
edited
Loading

Sol 3 Keyboard from RGBKB

Description

This adds QMK Keyboard support for the RGBKB Sol 3.
The Default keymap version is coming factory flashed on the Sol 3.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 31, 2021
drashna
drashna requested changes Jan 2, 2022
View reviewed changes
keyboards/rgbkb/sol3/config.h Outdated Show resolved Hide resolved
keyboards/rgbkb/sol3/keymaps/kageurufu/config.h Show resolved Hide resolved
keyboards/rgbkb/sol3/keymaps/kageurufu/config.h Outdated Show resolved Hide resolved
keyboards/rgbkb/sol3/keymaps/kageurufu/keymap.c Show resolved Hide resolved
keyboards/rgbkb/sol3/rules.mk Outdated Show resolved Hide resolved
keyboards/rgbkb/sol3/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@XScorpion2 XScorpion2 requested a review from drashna January 2, 2022 18:38
@Legonut
Copy link
Contributor

Legonut commented Jan 3, 2022

Tested and working on my Sol 3, approved by RGBKB (me)

@drashna drashna requested a review from a team January 3, 2022 17:18
fauxpark
fauxpark requested changes Jan 6, 2022
View reviewed changes
keyboards/rgbkb/sol3/rules.mk Show resolved Hide resolved
keyboards/rgbkb/sol3/rules.mk Outdated Show resolved Hide resolved
keyboards/rgbkb/sol3/keymaps/kageurufu/keymap.c Outdated Show resolved Hide resolved
@XScorpion2 XScorpion2 requested a review from fauxpark January 6, 2022 14:30
@XScorpion2
Copy link
Contributor Author

Code review changes applied @fauxpark

@drashna drashna requested a review from a team January 6, 2022 17:57
fauxpark
fauxpark requested changes Jan 16, 2022
View reviewed changes
keyboards/rgbkb/sol3/rules.mk Outdated Show resolved Hide resolved
@XScorpion2 XScorpion2 requested a review from fauxpark January 17, 2022 15:51
@XScorpion2
Copy link
Contributor Author

Bump, can this land before the breaking change merge?

@drashna drashna requested a review from a team January 22, 2022 03:28
fauxpark
fauxpark approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.noci file can be deleted since Travis is no longer running.

@drashna drashna merged commit ad70209 into qmk:develop Jan 22, 2022
@drashna
Copy link
Member

drashna commented Jan 22, 2022

Thanks!

@XScorpion2
Copy link
Contributor Author

no thank you @drashna and @fauxpark!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XScorpion2 @Legonut @drashna @fauxpark @kageurufu