Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Oneshot disabling #14934

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Conversation

drashna
Copy link
Member

@drashna drashna commented Oct 24, 2021

Description

found an issue where when oneshots was disabled (at runtime via the keycodes, not by the define), it would cause incorrect cleanup of keys. namely, noticed that it immediately released mousekeys, even when held down.

Also, completely disables the oneshot behavior, so that tap toggling doesn't work. OSM should work exactly as modifier keys, and OSL should work as MO, when disabled.

Types of Changes

  • Core
  • Bugfix
  • Enhancement/optimization

Issues Fixed or Closed by This PR

  • found by me

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team October 24, 2021 05:57
@github-actions github-actions bot added the core label Oct 24, 2021
@drashna drashna merged commit 2980c63 into qmk:develop Nov 1, 2021
@drashna drashna deleted the oneshot_fixup branch November 1, 2021 16:41
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants