Fix issues with Oneshot disabling #14934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
found an issue where when oneshots was disabled (at runtime via the keycodes, not by the define), it would cause incorrect cleanup of keys. namely, noticed that it immediately released mousekeys, even when held down.
Also, completely disables the oneshot behavior, so that tap toggling doesn't work. OSM should work exactly as modifier keys, and OSL should work as MO, when disabled.
Types of Changes
Issues Fixed or Closed by This PR
Checklist