Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce nibble oled_status keymap size #13813

Merged
merged 1 commit into from
Jul 31, 2021
Merged

Reduce nibble oled_status keymap size #13813

merged 1 commit into from
Jul 31, 2021

Conversation

jaygreco
Copy link
Contributor

Followed @drashna's advice for reducing size of wpm counter code -- this is the same optimization recommended in #13638.

Description

Removed sprintf and stdio. Tested locally.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested review from drashna and a team July 31, 2021 07:12
@drashna drashna merged commit 56200de into qmk:master Jul 31, 2021
@jaygreco jaygreco deleted the optimize_oled_status branch August 2, 2021 04:42
CharlesSchimmel pushed a commit to CharlesSchimmel/qmk_firmware that referenced this pull request Aug 8, 2021
@jaygreco
[Keyboard] Reduce nibble oled_status keymap size (qmk#13813)
9def0b3
VictorIsaacChavezEscamilla pushed a commit to VictorIsaacChavezEscamilla/qmk_firmware that referenced this pull request Aug 28, 2021
@jaygreco
[Keyboard] Reduce nibble oled_status keymap size (qmk#13813)
e26f4f4
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@jaygreco @nhongooi
[Keyboard] Reduce nibble oled_status keymap size (qmk#13813)
11b2f8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaygreco @drashna @fauxpark