Reduce NIBBLE oled_bongocat keymap size so it compiles

[jaygreco]

Description

Changed WPM counter string builder in order to get the nibble oled_bongocat keymap to compile (thanks to @drashna for the clever optimization).

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

N/A

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[drashna]

Actually, I would recommend reverting this change. You can save ~1.5K by making a simple change to how the WPM is rendered.

qmk_firmware/keyboards/nullbitsco/nibble/keymaps/oled_bongocat/keymap.c

Lines 164 to 165 in 336c8d3

	sprintf(wpm_str, ">%04d", get_current_wpm());
	oled_write_ln(wpm_str, false);

change this to:

    uint8_t n = get_current_wpm();
    char wpm_counter[4];
    wpm_counter[3] = '\0';
    wpm_counter[2] = '0' + n % 10;
    wpm_counter[1] = '0' + (n /= 10) % 10;
    wpm_counter[0] = '0' + n / 10 ;
    oled_write_P(PSTR("WPM: "), false);
    oled_write(wpm_counter, false);

You can remove the stdio.h include at the beginning of the file too.

This will maintain identical functionality, but use a lot less program memory.

[jaygreco]

Ayoooo, great feedback! Thanks for the heads up. I'll close this PR and revert + resubmit. That's a much better solution.

[drashna]

no need to have closed the PR. Changes to the branch would be reflected.

And yeah, for such a "simple" change, it's a huge savings! Been recommending it on any new PRs I've seen since it's such a big change.

[jaygreco]

🤦‍♂️ I should stay away from PRs late at night. Thanks! Will update. Appreciate the input and help as always @drashna 👍

[drashna]

🤦‍♂️ I should stay away from PRs late at night. Thanks! Will update. Appreciate the input and help as always @drashna 👍

I totally understand that feeling. And welcome!

[drashna]

Thanks!