Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Tron Guy Labs keyboard implementation. #13438

Merged
merged 17 commits into from
Jul 22, 2021
Merged

Initial Tron Guy Labs keyboard implementation. #13438

merged 17 commits into from
Jul 22, 2021

Conversation

jmaynard
Copy link

@jmaynard jmaynard commented Jul 3, 2021 •
edited by zvecr
Loading

Description

This PR adds support for the Tron Guy Labs replacement controller for the IBM M122 terminal keyboard. The layout is intended to provide as much 3270-like functionality as possible, to match the 3270 keyboard legends. There are two variants; one for the Teensy ++ 2.0 MCU, and one for the STM32F411 BlackPill. The two should function the same at the user level.
The changes are confined to the keyboards/tronguylabs directory.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@jmaynard jmaynard changed the title Initial keyboard implementation. Initial Tron Guy Labs keyboard implementation. Jul 3, 2021
zvecr
zvecr requested changes Jul 3, 2021
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All hardware files (*.pdf, *.zip, LICENSE) need to be removed.

You can host them in another repo, and link to them in the boards readme if you wish.

zvecr
zvecr requested changes Jul 3, 2021
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also advise restructuring.

keyboards/tronguylabs/ is your vendor folder and should not contain keyboard specific files like tronguylabs.h info.json rules.mk and should be moved to keyboards/tronguylabs/m122_3270

the rest would become something like....

keyboards/tronguylabs/m122_3270/teensy/
keyboards/tronguylabs/m122_3270/blackpill/
keyboards/tronguylabs/m122_3270/keymaps/default/

keyboards/tronguylabs/tronguylabs.c Outdated Show resolved Hide resolved
@jmaynard jmaynard requested a review from zvecr July 3, 2021 21:17
drashna
drashna reviewed Jul 4, 2021
View reviewed changes
keyboards/tronguylabs/m122_3270/config.h

#include "config_common.h"

#define VENDOR_ID 0x1209
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pid.codes vendor id 👍🏻

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on request there, but they haven't merged the PR yet...if they turn it down, I'll pick something else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive added the awaiting PR label while this is sill unresolved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For quick reference: pidcodes/pidcodes.github.com#656

zvecr
zvecr requested changes Jul 4, 2021
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, readme.md would need updating with

Make example for this keyboard (after setting up your build environment):

    make tronguylabs/m122-3270/blackpill:default
    make tronguylabs/m122-3270/teensy:default

@zvecr zvecr requested review from a team and drashna July 4, 2021 20:04
@zvecr zvecr added the awaiting_pr Relies on another PR to be merged first label Jul 4, 2021
fauxpark
fauxpark requested changes Jul 5, 2021
View reviewed changes
keyboards/tronguylabs/m122_3270/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tronguylabs/m122_3270/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/tronguylabs/m122_3270/readme.md Outdated Show resolved Hide resolved
keyboards/tronguylabs/m122_3270/readme.md Outdated Show resolved Hide resolved
keyboards/tronguylabs/m122_3270/rules.mk Outdated Show resolved Hide resolved
keyboards/tronguylabs/m122_3270/rules.mk Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Jul 22, 2021

Thanks!

@drashna drashna merged commit 8e905a7 into qmk:master Jul 22, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 22, 2021
Merge remote-tracking branch 'qmk/develop' into develop
412e2ae 
* qmk/develop: (141 commits)
  Implement GPIO abstraction for atsam (qmk#13567)
  [Keyboard][Bug] Add timer_avr to includes for broken builds (qmk#13641)
  [Keyboard] adds new revision: dztech/dz60rgb/v2_1 (qmk#13636)
  [Keyboard] Fixing info.json for h0oni/hotduck (qmk#13640)
  [Keyboard] Ymd40v2new layouts and fixed per-switch backlight (qmk#13622)
  [Bug] Develop - DC01 left (qmk#13597)
  [Keyboard] Fix clawsome/hatchback and reviung5 compile issues (qmk#13607)
  [Keyboard] add ogurec (qmk#13242)
  [Keyboard] Add Durgod Taurus K310 keyboard (qmk#12314)
  [Keyboard] Updated keyboard & keymaps (qmk#12667)
  [Keyboard] add SPRH keyboard (qmk#12999)
  Retain brightness with lighting layers (qmk#13025)
  [Keyboard] Add keypad Satxri6key (qmk#13423)
  [Keyboard] Initial Tron Guy Labs keyboard implementation. (qmk#13438)
  [Keyboard] Add Ristretto Keyboard (qmk#13479)
  [Keyboard] New Keyboard - OBE (qmk#13545)
  [Keyboard] Add personal planck keymap (qmk#13635)
  [Keymap] narze/xd004 (qmk#13634)
  [Keyboard] Add h0oni hotduck keyboard (qmk#13609)
  Fix API generation failure caused by GRS-70EC (qmk#13631)
  ...
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@jmaynard @drashna
@fauxpark @nhongooi
[Keyboard] Initial Tron Guy Labs keyboard implementation. (qmk#13438)
71f0e06 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Jay Maynard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
awaiting_pr Relies on another PR to be merged first keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmaynard @drashna @fauxpark @zvecr