Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] New Keyboard - OBE #13545

Merged
merged 42 commits into from
Jul 22, 2021
Merged

[Keyboard] New Keyboard - OBE #13545

merged 42 commits into from
Jul 22, 2021

Conversation

kylemccreery
Copy link
Contributor

Description

Initial PR for adding the OrangeBoyErgo (OBE) keyboard kit by MechWild. This is the default and VIA keymaps.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

kylemccreery and others added 29 commits January 11, 2021 16:20
…g old split source code. running into an issue now with col1 and row1 both not responding.
…y for eeprom addition for next version. Cleaned up files in general.
@kylemccreery kylemccreery requested a review from drashna July 20, 2021 02:15
@kylemccreery
Copy link
Contributor Author

@drashna retagging for rereview was a mistake. I was just gonna comment asking if you need to rerequest qmk reviewers. My bad.

@drashna drashna requested a review from a team July 20, 2021 03:35
@drashna
Copy link
Member

drashna commented Jul 20, 2021

No worries

keyboards/mechwild/obe/readme.md Outdated Show resolved Hide resolved
keyboards/mechwild/obe/f411/rules.mk Outdated Show resolved Hide resolved
keyboards/mechwild/obe/f401/rules.mk Outdated Show resolved Hide resolved
keyboards/mechwild/obe/config.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team July 20, 2021 05:06
@kylemccreery
Copy link
Contributor Author

@fauxpark I added the BOOTLOADER section to the rules.mk files while removing the STM32_BOOTLOADER_ADDRESS per your comment on #12956

Please advise if that was not correct. It seems a lot like I started writing this firmware directly before a lot of stm32 changes came into play so I was immediately outdated on stuff before submitting for PR

keyboards/mechwild/obe/f411/rules.mk Outdated Show resolved Hide resolved
keyboards/mechwild/obe/f401/rules.mk Outdated Show resolved Hide resolved
@fauxpark
Copy link
Member

@kylemccreery good catch, I completely forgot about that.

@kylemccreery
Copy link
Contributor Author

@kylemccreery good catch, I completely forgot about that.

I only knew because I had to look up why you suggested the removal in the first place haha. I am glad a lot of the stm32 stuff is advancing so much recently.

Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter is complaining about missing readmes, but there is one at the top level so it's OK.

@drashna
Copy link
Member

drashna commented Jul 22, 2021

Thanks!

@drashna drashna merged commit 5766b9b into qmk:master Jul 22, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 22, 2021
* qmk/develop: (141 commits)
  Implement GPIO abstraction for atsam (qmk#13567)
  [Keyboard][Bug] Add timer_avr to includes for broken builds (qmk#13641)
  [Keyboard] adds new revision: dztech/dz60rgb/v2_1 (qmk#13636)
  [Keyboard] Fixing info.json for h0oni/hotduck (qmk#13640)
  [Keyboard] Ymd40v2new layouts and fixed per-switch backlight (qmk#13622)
  [Bug] Develop - DC01 left (qmk#13597)
  [Keyboard] Fix clawsome/hatchback and reviung5 compile issues (qmk#13607)
  [Keyboard] add ogurec (qmk#13242)
  [Keyboard] Add Durgod Taurus K310 keyboard (qmk#12314)
  [Keyboard] Updated keyboard & keymaps (qmk#12667)
  [Keyboard] add SPRH keyboard (qmk#12999)
  Retain brightness with lighting layers (qmk#13025)
  [Keyboard] Add keypad Satxri6key (qmk#13423)
  [Keyboard] Initial Tron Guy Labs keyboard implementation. (qmk#13438)
  [Keyboard] Add Ristretto Keyboard (qmk#13479)
  [Keyboard] New Keyboard - OBE (qmk#13545)
  [Keyboard] Add personal planck keymap (qmk#13635)
  [Keymap] narze/xd004 (qmk#13634)
  [Keyboard] Add h0oni hotduck keyboard (qmk#13609)
  Fix API generation failure caused by GRS-70EC (qmk#13631)
  ...
@kylemccreery kylemccreery deleted the obe branch September 9, 2021 03:17
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants