Fix submodule check for qmk setup #11379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initialization of the submodules would succeed, but the result of the subsequent
check_submodules() run wasn't checked correctly.
Description
When bootstrapping a
qmk_firmware
repository, according to the documentation, there is an issue when callingqmk setup
. That is,qmk
is being installed viapip
, not the one underbin/qmk
. According to the docs.Anyhow, the setup process asks to initialize the git submodules for the user, which it does on confirmation, but the check fails with a
Not an iteratable
-Error. I deem the problem fixed by this PR, but 1. I don't code python usually, 2. I only invested the minimum time.I'm still confused why there is a
bin/qmk
but it doesn't havesetup
, yet the one installed viapip install
still uses the local libraries inlib/python
. Well. I hope this PR helps, but if not, it's fine with me.Types of Changes
Checklist