Skip to content

Commit

Permalink
Fix submodule check for qmk setup (qmk#11379)
Browse files Browse the repository at this point in the history
The initialization of the submodules would succeed, but the result of the subsequent
check_submodules() run wasn't checked correctly.

Co-authored-by: Stefan Schulze <[email protected]>
  • Loading branch information
graupe and Stefan Schulze authored Feb 16, 2021
1 parent d6bef58 commit b0b901b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/python/qmk/cli/doctor.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@ def doctor(cli):
submodules.update()
sub_ok = check_submodules()

if CheckStatus.ERROR in sub_ok:
if sub_ok == CheckStatus.ERROR:
status = CheckStatus.ERROR
elif CheckStatus.WARNING in sub_ok and status == CheckStatus.OK:
elif sub_ok == CheckStatus.WARNING and status == CheckStatus.OK:
status = CheckStatus.WARNING

# Report a summary of our findings to the user
Expand Down

0 comments on commit b0b901b

Please sign in to comment.