Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate our JSON data using json_schema #11101

Merged
merged 14 commits into from
Jan 8, 2021
Merged

Validate our JSON data using json_schema #11101

merged 14 commits into from
Jan 8, 2021

Conversation

skullydazed
Copy link
Member

@skullydazed skullydazed commented Dec 1, 2020 •
edited
Loading

Description

This builds on #10817, and should be merged after that one.

Types of Changes

  • Core
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team December 1, 2020 20:54
@github-actions github-actions bot added cli qmk cli command keyboard python labels Dec 1, 2020
@skullydazed skullydazed mentioned this pull request Dec 16, 2020
Closed
13 tasks
@skullydazed skullydazed force-pushed the info_json_config branch 2 times, most recently from 2354231 to 6fba22c Compare December 30, 2020 18:25
Base automatically changed from info_json_config to develop December 30, 2020 18:27
@skullydazed skullydazed marked this pull request as ready for review December 30, 2020 19:03
@daskygit daskygit mentioned this pull request Jan 6, 2021
Closed
@daskygit
Copy link
Member

daskygit commented Jan 6, 2021

After testing this because of the bootmagic lite issue I noticed running make clean would then cause the keyboard build to fail (crkbd:default). It doesn't seem to be limited to that keymap either, quite a few are failing when running make all:default.

I honestly don't know if this is an issue with how I tested the pull request (git fetch upstream pull/11101/head:test/11101) then switching to that branch. I also tried merging develop into this with the same result.

I thought I'd be cautious and mention it here.

@skullydazed
Copy link
Member Author

@daskygit thanks for the report! I've fixed that in 0d391cd90.

@github-actions github-actions bot added the core label Jan 7, 2021
@github-actions github-actions bot removed the core label Jan 8, 2021
@skullydazed
Copy link
Member Author

Travis failures are not related to this PR, and exist currently in develop.

@skullydazed skullydazed merged commit a828a82 into develop Jan 8, 2021
@skullydazed skullydazed deleted the json_schema branch January 8, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
cli qmk cli command keyboard python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skullydazed @daskygit @Erovia