Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [develop] BOOTMAGIC_ENABLE not being parsed correctly at keyboard level #11457

Closed
daskygit opened this issue Jan 6, 2021 · 1 comment
Closed

[Bug] [develop] BOOTMAGIC_ENABLE not being parsed correctly at keyboard level #11457

daskygit opened this issue Jan 6, 2021 · 1 comment

Comments

@daskygit
Copy link
Member

daskygit commented Jan 6, 2021

qmk_firmware/lib/python/qmk/cli/generate/rules_mk.py

Line 37 in f926903

enabled = 'yes' if enabled else 'no'

The above line parses BOOTMAGIC_ENABLE = lite from rules.mk at keyboard level into BOOTMAGIC_ENABLE = yes while generating .build/keyboard/src/rules.mk.

The keymap rules.mk seems to work correctly and overrides as expected.
@daskygit
Copy link
Member Author

daskygit commented Jan 6, 2021

Erovia pointed out pr #11101 should fix this, after some quick testing it does.

@daskygit daskygit closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daskygit