Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean ChibiOS platform files #10505

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Clean ChibiOS platform files #10505

merged 3 commits into from
Oct 7, 2020

Conversation

riblee
Copy link
Contributor

@riblee riblee commented Oct 1, 2020

Description

Remove unnecessary ChibiOS platform files

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc
Copy link
Member

tzarc commented Oct 3, 2020

Some of these are different to the generated changes I have staged in #10418 -- 1a0ebee -- yours don't seem to match your original inputs.

e.g. STM32_I2C_USE_I2C1 and STM32_PWM_USE_TIM5 were FALSE in the old copy, yet in your new commit they're both TRUE.

@tzarc tzarc requested review from tzarc and a team October 3, 2020 18:13
@tzarc tzarc added the keyboard label Oct 3, 2020
@riblee
Copy link
Contributor Author

riblee commented Oct 4, 2020

I was messing around with the OLED driver and these changes are the leftovers from it, I've removed them.

@drashna drashna requested a review from a team October 4, 2020 23:02
tzarc
tzarc requested changes Oct 7, 2020
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all three of the ChibiOS config files can be deleted outright, if you're not overriding anything in them. If you can confirm that it's all working after doing so, I think it'd be the safest option.

keyboards/handwired/riblee_f401/halconf.h Outdated Show resolved Hide resolved
keyboards/handwired/riblee_f401/mcuconf.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team October 7, 2020 23:18
@tzarc tzarc merged commit d79fe65 into qmk:master Oct 7, 2020
barrettclark pushed a commit to barrettclark/qmk_firmware that referenced this pull request Oct 8, 2020
Merge remote-tracking branch 'upstream/master' into master
5a529c4 
* upstream/master: (81 commits)
  [Keyboard] New keyboard - eiri (qmk#10529)
  [Keymap] Add niu mini dye sub keymap (qmk#10525)
  Clean ChibiOS platform files (qmk#10505)
  [Keyboard] LeftyNumpad Keyboard (qmk#10500)
  [Keyboard] add maja capslock indicator (qmk#10151)
  Fix issue introduced by PR#10404 (qmk#10559)
  Docs: fix udev rules
  [CLI] Add c2json (qmk#8817)
  Improve LAYOUT macro searching (qmk#9530)
  CLI: update subcommands to use return instead of exit() (qmk#10323)
  Fixes small typo in docs (qmk#10515)
  Update personal keymap for Let's Split keyboard. (qmk#10536)
  [Keymap] Move my custom functions and keymaps to userspace (qmk#10502)
  [Keyboard] add support for ymd75 rev3 (qmk#10483)
  [Keyboard] Add soy20 PCB (qmk#10440)
  Fix for MIDI sustain effect issue (qmk#10361)
  format code according to conventions [skip ci]
  [Keyboard] Add Yugo-M Controller (qmk#10389)
  [Keymap] Add onekey keymap for OLED testing (qmk#10380)
  [Keymap] Add winterNebs keymaps  (qmk#10328)
  ...
@alabahuy
Copy link
Contributor

hii @riblee, i see you can make oled work on stm32f4, can oled work on bluepill stm32f1 too?
Any clues and tips would be appreciated. thanks you

@riblee riblee deleted the cleanup branch October 27, 2020 12:53
@riblee
Copy link
Contributor Author

riblee commented Oct 27, 2020

Hi @alabahuy I think the OLED should work on the bluepill as well, I'll try it out this week and send you the steps to reproduce.
BTW I just followed the OLED guide here

@alabahuy
Copy link
Contributor

hi @riblee thank you very much for the information. I have tried it but OLED still doesn't work. when I add "OLED_DRIVER_ENABLE = yes" then the switchs and OLED on the keyboard don't work. Switches work again when I delete "OLED_DRIVER _ENABLE = yes".
can i see the qmk code you made? I am very helpful if you want to help me

@riblee
Copy link
Contributor Author

riblee commented Oct 27, 2020

Hi @alabahuy I will create a PR with my changes in a couple of hours so you can see them. BTW what type of OLED screen do you got?

Also you can PM me in the QMK discord so we can discuss it further, my username is riblee.

@alabahuy
Copy link
Contributor

HI @riblee i will wait for your pull, i am using ssd1306 0.91 inch. I didn't join discord qmk, I joined Artkey, jtk and kbdfans.

kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@riblee
Clean ChibiOS platform files (qmk#10505)
ec1717f 
* Clean ChibiOs platform files

* Remove I2C and timer definitions

* Remove unnecessary files and rename readme

Co-authored-by: Janos Daniel Reibl <[email protected]>
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
@riblee
Clean ChibiOS platform files (qmk#10505)
41d9014 
* Clean ChibiOs platform files

* Remove I2C and timer definitions

* Remove unnecessary files and rename readme

Co-authored-by: Janos Daniel Reibl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc requested changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@nooges nooges nooges approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@riblee @tzarc @alabahuy @nooges @drashna @fauxpark