Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChibiOS upgrade: keyboard conf migrations (phase 1) #10418

Merged
merged 94 commits into from
Dec 5, 2020
Merged

ChibiOS upgrade: keyboard conf migrations (phase 1) #10418

merged 94 commits into from
Dec 5, 2020

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Sep 23, 2020 •
edited
Loading

Description

Performs the config migrations for ChibiOS-based boards.

This PR includes the set of keyboards which do not require board changes, or even if the board has changed the resulting binary has a sha1 match before and after the configuration file migration has occurred.

All builds have been executed with the following command:

make -j$(nproc) ${KEYBOARD_BUILD}:default COMMAND_ENABLE=no SKIP_GIT=yes

The keyboards listed at the end do require modification, and will result in further PRs to allow for board-specific validation without holding up other merges.

Listing of boards successfully migrated:

                                    acheron/arctic - 8d3d233f15bf5d396e29abb94f943a89b0b828d1
                                    acheron/austin - beabc6204533de80704684de9ff7790895f319e1
                                  acheron/keebspcb - e14a96e99aab54aefebc1d3d24d64b0082db7842
                               aeboards/ext65/rev2 - 0b97daef994903585be2768b6aaffc4da97ec617
                                         ai03/vega - 7e5f208278309681fd1db8b2629890b813fdf938
                                        at_at/660m - e30393b6546454f9939c1187aa9c6539f1ef76c1
                               bt66tech/bt66tech60 - a7f4e8a224132830447d12c92d146997f9b56b7d
                                   cannonkeys/an_c - e7320dc09377fdad749e382b3986f2241633214b
                                  cannonkeys/atlas - 063a8eaea7e68607b725ad06777c49d34686b433
                              cannonkeys/chimera65 - 01ce66c862a5cd98183b10e992939a55038779bc
                                   cannonkeys/db60 - 45636d0b3cf951cef51a5b19678e2da549efd14f
                         cannonkeys/devastatingtkl - 709e0155c421991fad283d38c28f850320ed4730
                              cannonkeys/instant60 - 7e530e10794183d684a328f01b9b0743907440c7
                              cannonkeys/instant65 - c8de288708d0586337cb7137ae54d97e1ddc90a6
                                cannonkeys/iron165 - 3a3c0273e227fd15ab3527e4aa557b94d0b69248
                          cannonkeys/obliterated75 - cdf834802ae77b1bbd4876eb8c34c19a83ad95cd
                                cannonkeys/ortho48 - 3432ff13c83a6358eca44b37f72b18882eeda699
                                cannonkeys/ortho60 - 95be42a23798cc8f9b04175d4892b712d871a52d
                                cannonkeys/ortho75 - e1149893fd01e853124808b45d521b61a7638eb9
                             cannonkeys/practice60 - 6e4da87f0a766cf2665e9b4aa8e3ab33017cf745
                             cannonkeys/practice65 - c436c06829123503073b3a9c5a1c0acfc2dbe2e5
                               cannonkeys/rekt1800 - 43e8e21b62531534afeaa241f4c683fbdb60a8e0
                         cannonkeys/satisfaction75 - 28ff9a8a11ad1de9d09ec85fab2af906b7c27d6a
                               cannonkeys/savage65 - 53eaefae56020b536d4934686506d5d1fe51b6e0
                                  cannonkeys/tmov2 - 8b1ced8ff7dc368afa268104cd5192bb1bfc8a1c
                                    chavdai40/rev1 - b166af66b084077764b705c9428725cde0b0ce51
                                    chavdai40/rev2 - 0048c8ec8c28f1dfa5d1a37348524899595d8325
                                cheshire/curiosity - f1636e53638ce2e798070e6e622fd88a08982d5a
                                      clueboard/60 - bb5057d4a2976b6530fe2e345a4153de2f7c042d
                         clueboard/66_hotswap/gen1 - 03fe10f4de7b67e5f1cf0a7d576f82676adf4261
                                 clueboard/66/rev4 - 878e38a34f97b32d9d109a6d98f98bc385d84864
                                 coarse/cordillera - 5cae5c643e96d03bddcbb73e76e225ea5f82fef3
                        converter/siemens_tastatur - 48f82cd227836878967dfa0fe0411f7d877a124c
                                  ergodox_infinity - 8df21d6129eef47d7a5ced92715e5bdbfb0151e5
                                        function96 - deecdcdca34c88058f820f0e2bc9f112458c85c5
                          generic_panda/panda65_01 - 8522d8107edcf71758f3be7298c0bc18fa7f6706
                                       hadron/ver3 - 632af7727b767720c699abdff770edc9682928ee
                                   handwired/ck4x4 - a4cb9b5b8c3a162083677b14b105edbc1bca2baf
                               handwired/co60/rev6 - be1688eeabd83a7f576d9e4e23e24d56b8dc251b
                               handwired/co60/rev7 - d196c5772859ddee695bda5b0e9f0944a0f350f8
                   handwired/onekey/blackpill_f401 - 8387bfd56888fc1605d293dc0071b4ec94b23991
                   handwired/onekey/blackpill_f411 - 855efdb2f60c384edf64773c0f4ff4b7ea8ae4c9
                         handwired/onekey/bluepill - 60d8555b174dbdabae196a4cc5eccfee4bdd9529
                    handwired/onekey/stm32f0_disco - 9bc12e29f5a4e4b9ec0f34987559e5e11de4bb48
                        handwired/onekey/teensy_32 - 17459dd8e71b3a33270037878bdbd04151af196b
                        handwired/onekey/teensy_lc - 3a9aed4681c287176efe31c988340ca43ad27a9d
                   handwired/pill60/blackpill_f401 - 5b652354ae957e86e211dcef29f8f27320b31180
                   handwired/pill60/blackpill_f411 - 580255c171e95b5bca53b14a13ae018a73d18414
                         handwired/pill60/bluepill - 29109b54137ea94ac266c604991cff87516689ff
                             handwired/riblee_f401 - dc68c31d7ca8ae0fad7e7ad8bdd63406155ff363
                             handwired/riblee_f411 - cf0fadff4c98d41cf9bdddbe1ead15c79be941b9
                           handwired/steamvan/rev1 - 743b395ac87b918b6be4614c9e120e80a9f049d4
                                    handwired/t111 - 99b61ae5692ee4b2101673d1a896cd7a5831bcfa
                            handwired/twadlee/tp69 - 3ab2753c40e947a726ece6c825493ebc87ecf20e
                                    handwired/z150 - 78808b0c8671e2386b9ba65dbd647d613d92f253
                                      hs60/v2/ansi - 7bcd152c269803de8f96416ba26e939c0420ceae
                                      hs60/v2/hhkb - d77f393d2811bd104b05c4530bf1083d75856b7a
                                       hs60/v2/iso - 5d3d20de919fca3b64cb7548cad46e8d35d7cc04
                                        infinity60 - dbcbb2f58ee499252b0879d68d9beec08a8433bc
                                            k_type - 492f476177da95495442d1e173391e3c17324a70
                                  keebio/bdn9/rev2 - 4dbb5d606b3d9060ad01a437978220fe0f1fc5b2
                                   keebio/choconum - 1521e634088a30114cd12b7b6bbd2cca5331c822
                                keebwerk/mega/ansi - 10e32718c7bfff2f6bd8dd2159a15bef0f4acbf9
                               misterknife/knife66 - cf2f3d26103036d79bf7fcec204e13899e33fbe3
                                              nack - ba7f421d5670e672c5c14fd5f80c0f86447c1468
                                          nebula12 - aedb11fa894dc19513462f054a9fa00f5c195adc
                                          nebula68 - 6bed6afb2fd84ef9069b757f1d1e87fc1cbe290c
                                             nemui - 86ed80ea8565d7d0f39512a9032cc5e1b306fcff
                                              nk65 - 75b2484741a96dcbff14e94c44443bb33ad73dce
                                              nk87 - f719a739a3d2c0969c79c1ace5fe9a7d6f05cc22
                               peiorisboards/ixora - b5adf1090fb4c6278d8990ce9132727a13ca3cd7
                                           phoenix - 21bfb14c52451899dadf545b78a8e88b22a420f0
                                           polilla - 3ba5f326b268362c9aba570b1510e1c61009ba96
                                  primekb/meridian - df266e25c682a8ed3318faa186805683014ccec4
                                   projectkb/alice - eee7210f618588b2c5c6367c8a0318427d09da52
                             projectkb/signature87 - 617430e601981f0bb5fbcce42eee53107d5161b8
                              ramonimbao/squishy65 - 88e4cd3db8db61ccf9daed5405cf5eeb32f8043e
                                   ramonimbao/wete - f0e90d943d8749e802b6bba619ce943b568a7f65
                                     rart/rartlice - f7a6b58e6cadd4102fcf5f89d054d1fbdc5809d0
                                          retro_75 - 34c7b291fb2443bf8cb69fb9ee676190c736bf00
                                    rocketboard_16 - 24e6503a7a5259934a80dd96dd37d3281b4240d3
                                       satt/vision - c926d6433d8b2dc1d74623184255016bdd36ae22
                                tkc/candybar/lefty - 2f269cbed5dcec61bb0c7904a46436f110dc0ae1
                               tkc/candybar/righty - 9b1448b2ccbcf8a4d1e5ad74d8ad5933003ee9a2
                                    tkc/godspeed75 - 2cfed58d44a7eef8f341ff24e0136511e03aa78d
                              tkw/stoutgat/v2/f411 - b094651ec61c79099de3e6e4991319816ac464c1
                                     viktus/styrka - f3f678ea55126c9965f24da6fffc9bbbd8b24aa9
                                             vinta - e5403dc6bbf47f35a53cf43b1b1d130f05552f16
                               westfoxtrot/prophet - 0e4d6987ffa6430720804e7bc1502ab6c3dcb879
                                          whitefox - 5ca6de6fb09d8c2cfa996b65732fcd55391053ff
                                  wolfmarkclub/wm1 - 2d8294e29b08f5af5406988a284483d1694ed36c
                                    xelus/kangaroo - f9697ba27d4e6c36a1cfd9e2657eac35dfa3be99
                                xelus/trinityxttkl - a457601b446ea9b4e9e28d2ba304a4bcdb934257
                               xelus/valor_frl_tkl - 27ec14b9ee0e5cb2d026af500d16b17d4c2885e2
                                        zoo/wampus - 926487c1f50c1c5eb0608ca7dc1184881d54d35e
                             zvecr/split_blackpill - 02f4393d01e0a70c94af48fa979ff0229732e8ca
                                   zvecr/zv48/f401 - 8b1766a24f943b9b0ba756c6fe340ba69d5e14e3
                                   zvecr/zv48/f411 - 09ba645092eb7f3d41da0d5e6727f2f4f97033c0

Listing of boards left outstanding:

8 boards outstanding:
akegata_denki/device_one: BOARD=DEVICE_ONE
dekunukem/duckypad: BOARD=GENERIC_STM32_F072XB
ergodox_stm32: BOARD=ERGODOX_STM32_BOARD
handwired/bluepill/bluepill70: BOARD=GENERIC_STM32_F103
jm60: BOARD=JM60_BOARD
matrix/m20add: BOARD=m20add_bd
matrix/noah: BOARD=noah_bd
xiaomi/mk02: BOARD=ST_STM32F072B_DISCOVERY

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team September 23, 2020 23:05
@tzarc tzarc self-assigned this Sep 23, 2020
@tzarc
Copy link
Member Author

tzarc commented Sep 23, 2020

Part of #8976.

@tzarc tzarc mentioned this pull request Sep 23, 2020
Closed
11 tasks
@tzarc tzarc force-pushed the generated-chibios-conf-migration branch 8 times, most recently from 1f48802 to 9f6272b Compare September 25, 2020 09:19
@tzarc tzarc force-pushed the generated-chibios-conf-migration branch 3 times, most recently from 8d50c9d to 60e63c0 Compare October 1, 2020 22:52
This was referenced Oct 3, 2020
Merged
Merged
@tzarc tzarc force-pushed the generated-chibios-conf-migration branch 2 times, most recently from 0f0b2e7 to 3a17f41 Compare October 5, 2020 04:45
@tzarc tzarc mentioned this pull request Oct 6, 2020
Merged
14 tasks
@fauxpark fauxpark mentioned this pull request Oct 9, 2020
Merged
14 tasks
@tzarc tzarc force-pushed the generated-chibios-conf-migration branch from 3a17f41 to 6f22943 Compare October 20, 2020 22:21
tzarc added 21 commits December 4, 2020 11:02
@tzarc
ChibiOS conf upgrade for ramonimbao/squishy65
306a88e 
 ramonimbao/squishy65 - 88e4cd3db8db61ccf9daed5405cf5eeb32f8043e
@tzarc
ChibiOS conf upgrade for ramonimbao/wete
1de4cde 
 ramonimbao/wete - f0e90d943d8749e802b6bba619ce943b568a7f65
@tzarc
ChibiOS conf upgrade for rart/rartlice
7c192a9 
 rart/rartlice - f7a6b58e6cadd4102fcf5f89d054d1fbdc5809d0
@tzarc
ChibiOS conf upgrade for retro_75
551bca9 
 retro_75 - 34c7b291fb2443bf8cb69fb9ee676190c736bf00
@tzarc
ChibiOS conf upgrade for rocketboard_16
0bb1a2c 
 rocketboard_16 - 24e6503a7a5259934a80dd96dd37d3281b4240d3
@tzarc
ChibiOS conf upgrade for satt/vision
58c693e 
 satt/vision - c926d6433d8b2dc1d74623184255016bdd36ae22
@tzarc
ChibiOS conf upgrade for tkc/candybar
93c6b1b 
 tkc/candybar/lefty - 2f269cbed5dcec61bb0c7904a46436f110dc0ae1
 tkc/candybar/righty - 9b1448b2ccbcf8a4d1e5ad74d8ad5933003ee9a2
@tzarc
ChibiOS conf upgrade for tkc/godspeed75
86fa441 
 tkc/godspeed75 - 2cfed58d44a7eef8f341ff24e0136511e03aa78d
@tzarc
ChibiOS conf upgrade for tkw/stoutgat/v2/f411
9fc9da3 
 tkw/stoutgat/v2/f411 - b094651ec61c79099de3e6e4991319816ac464c1
@tzarc
ChibiOS conf upgrade for viktus/styrka
32d9a26 
 viktus/styrka - f3f678ea55126c9965f24da6fffc9bbbd8b24aa9
@tzarc
ChibiOS conf upgrade for vinta
4e9c4e2 
 vinta - e5403dc6bbf47f35a53cf43b1b1d130f05552f16
@tzarc
ChibiOS conf upgrade for westfoxtrot/prophet
55a4d5b 
 westfoxtrot/prophet - 0e4d6987ffa6430720804e7bc1502ab6c3dcb879
@tzarc
ChibiOS conf upgrade for whitefox
8be4ccc 
 whitefox - 5ca6de6fb09d8c2cfa996b65732fcd55391053ff
@tzarc
ChibiOS conf upgrade for wolfmarkclub/wm1
5a76452 
 wolfmarkclub/wm1 - 2d8294e29b08f5af5406988a284483d1694ed36c
@tzarc
ChibiOS conf upgrade for xelus/kangaroo
ab7d8ba 
 xelus/kangaroo - f9697ba27d4e6c36a1cfd9e2657eac35dfa3be99
@tzarc
ChibiOS conf upgrade for xelus/trinityxttkl
052884c 
 xelus/trinityxttkl - a457601b446ea9b4e9e28d2ba304a4bcdb934257
@tzarc
ChibiOS conf upgrade for xelus/valor_frl_tkl
af6c827 
 xelus/valor_frl_tkl - 27ec14b9ee0e5cb2d026af500d16b17d4c2885e2
@tzarc
ChibiOS conf upgrade for zoo/wampus
edf7252 
 zoo/wampus - 926487c1f50c1c5eb0608ca7dc1184881d54d35e
@tzarc
ChibiOS conf upgrade for zvecr/split_blackpill
bf19793 
 zvecr/split_blackpill - 02f4393d01e0a70c94af48fa979ff0229732e8ca
@tzarc
ChibiOS conf upgrade for zvecr/zv48/f401
1408ec9 
 zvecr/zv48/f401 - 8b1766a24f943b9b0ba756c6fe340ba69d5e14e3
@tzarc
ChibiOS conf upgrade for zvecr/zv48/f411
7b63e44 
 zvecr/zv48/f411 - 09ba645092eb7f3d41da0d5e6727f2f4f97033c0
@tzarc tzarc force-pushed the generated-chibios-conf-migration branch from 7844d87 to 7b63e44 Compare December 4, 2020 02:11
@github-actions github-actions bot removed the core label Dec 4, 2020
@tzarc tzarc removed the awaiting_pr Relies on another PR to be merged first label Dec 4, 2020
@tzarc tzarc marked this pull request as ready for review December 4, 2020 03:29
@tzarc tzarc requested a review from a team December 4, 2020 03:29
@tzarc
Copy link
Member Author

tzarc commented Dec 4, 2020

Marking this as ready for review again -- there are 8 outstanding boards, which will receive dedicated PRs due to non-standard board files.

@tzarc tzarc merged commit f1fef16 into qmk:develop Dec 5, 2020
@tzarc tzarc deleted the generated-chibios-conf-migration branch December 5, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@nooges nooges nooges approved these changes

Assignees

@tzarc tzarc

Labels
enhancement in progress keyboard optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tzarc @nooges @fauxpark @noroadsleft