-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infinity ErgoDox] How to enable backlight support? #720
Comments
Hi @ickerwx, Yes, the Infinity Ergodox backlight support is not properly integrated into the QMK firmware yet. In my TMK fork, which I made before moving over to QMK, things worked a bit differently. Although even there I didn't have support for dynamically changing the backlight. I could have got the same system working for QMK quite quickly, but I didn't want to do that. Instead I have been thinking about something that would work well with all kinds of keyboards and described in #717. The progress towards that have been quite slow, because first I needed proper unit test support, which in turn required some bigger changes to the makefile system. However now that those two things are done, I will finally have the time to start fixing the LCD and backlight support for the Infinity Ergodox. So I hope that we will have something working pretty soon. |
Alright, thanks for the info. I wasn't aware how much of the Infinitx Ergodox support is your work, thanks a lot for this, you're awesome. |
Hey buddy, any news on this? I'd love to program the backlights and LCD screens :). |
keyboards/ergodox/keymaps/swissgerman/keymap.c shows one way to change the LCD backlight color to show the current layer. So I did that in my fork too, plus using the hacks from last summer to have layer information on the LCD, and setting a constant key backlight level. I don't have the increment/decrement working yet. Seems like it needs a better architecture though: one should be able to choose basic behavioral features without needing to copy code like this into every keymap. |
@ec1oud Nice. Can you please elaborate on the "hacks from last summer" ? And if I were to clone your fork, what other changes have you made? Thank you sir! |
It was based on some sample visualization code from fredizzimo. The LCD has text showing which layer you are on, and the LCD backlight color changes depending on the layer, and I just want to have my keys illuminated so I didn't retain fredizzimo's visualization which put those backlight LEDs in motion, but the startup_animation is there, commented out. The code is in my keymap: keyboards/ergodox/keymaps/ecloud-qwerty, so you'll probably have to port such changes to your own favorite layout, unless you like mine. ;-) Other changes you probably don't need are the previous patches where I was modifying the default OS X keymap (that was from before the subproject restructuring, and before there were so many keymaps to choose from). But if you aren't building with that keymap, they won't matter. I could make it less of a mess, but figured I'd see what architecture fredizzimo is going to come up with. |
Hey you guys, Am I working on a lost cause here? |
The LCD support is now merged and working. Not using the effect system that I was planning to do, but using the old visualizer code. The effect system is still on my roadmap, but it won't be too different from what we have now, it will just make things easier to use. So I'm closing this. |
- check for and remove trailing extension for JSON when importing keymap Issue qmk#719
I have
BACKLIGHT_ENABLE = yes
set in my keymap's Makefile and have a key that essentially callsbacklight_step()
when pressed. The code is copied from my Preonic keymap where it works like it should. Still, when I press the respective key on my Infinity Ergodox the backlight stays off.I flashed the Kiibohd firmware, the LEDs light up like they should here, so it's not a hardware issue.
Do I have to do anything else beside setting
BACKLIGHT_ENABLE
in the Makefile and callingbacklight_step()
?The text was updated successfully, but these errors were encountered: