Remove the includenodoc and customcarditem directives
#270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
requested review from
stefan-woerner,
woodsp-ibm and
t-imamichi
as code owners
Eric-Arellano
commented
May 12, 2023
Comment on lines
-7
to
-10
| try: | ||
| FileNotFoundError | ||
| except NameError: | ||
| FileNotFoundError = IOError |
There was a problem hiding this comment.
Python 2 compatibility code, I believe.
Pull Request Test Coverage Report for Build 4960787795
💛 - Coveralls |
woodsp-ibm
added
stable backport potential
woodsp-ibm
approved these changes
May 12, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 12, 2023
* Remove the `includenodoc` and `customcarditem` directives * Fix fmt (cherry picked from commit 86af1b7)
mergify bot
added a commit
that referenced
this pull request
May 12, 2023
* Remove the `includenodoc` and `customcarditem` directives * Fix fmt (cherry picked from commit 86af1b7) Co-authored-by: Eric Arellano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to grep, these weren't actually used.
CustomCalloutItemDirectiveis used though. It's used in a few other projects too, so I'm likely going to move this toqiskit_sphinx_themein its 1.13 release so that you don't have to copy and paste the code. Tracked by Qiskit/qiskit_sphinx_theme#323.