Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate custom_directives.py #323

Closed
Eric-Arellano opened this issue May 12, 2023 · 1 comment · Fixed by #326
Closed

Deduplicate custom_directives.py #323

Eric-Arellano opened this issue May 12, 2023 · 1 comment · Fixed by #326
Assignees
Milestone

Comments

@Eric-Arellano
Copy link
Collaborator

Follow up to #262, which removes the Sphinx Gallery directives. Confirm we are using them in every repository and delete if not. If enough people are using them, migrate it to qiskit_sphinx_theme.

❯ fd custom_directives.py
qiskit-finance/docs/custom_directives.py
qiskit-machine-learning/docs/custom_directives.py
qiskit-metapackage/docs/custom_directives.py
qiskit-nature/docs/custom_directives.py
qiskit-optimization/docs/custom_directives.py

@Eric-Arellano
Copy link
Collaborator Author

Eric-Arellano commented May 12, 2023

Turns out that the only directive people are now using is customcalloutitem customcarditem. I have finished opening PRs to remove the 3 other directives from each project.

So, the next steps are:

  1. Confirm we want to keep customcalloutitem and customcarditem
  2. Move them into qiskit_sphinx_theme.

Eric-Arellano added a commit that referenced this issue May 16, 2023
)

Closes #323. These
are used by several Qiskit projects, so we should de-duplicate them.

![Screenshot 2023-05-16 at 10 02 55
AM](https://github.com/Qiskit/qiskit_sphinx_theme/assets/14852634/9c672417-6451-4547-bc36-10709f7f3880)


## Alternative considered: stop using these elements


For example, these elements will be somewhat tricky to get working with
Furo: #327.

We considered removing these design elements and instead using standard
Sphinx. For example, rather than having `qiskit-call-to-action-item`
with its clickable button to go to a URL, we could instead rely on
normal Sphinx links, or the left table of contents, and decide we don't
care about the button.

We decided that we like these design elements enough to keep them. It
would be a UX regression to remove them. We may want to improve the
styling—but we will still need the RST directive. We may also remove
these directives in some future, but only after finding a better
alternative.

---------

Co-authored-by: Abby Mitchell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant