Upgrade tach to 0.15.0, use 'interfaces' instead of strict mode #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the patch! I updated the dependencies lock file as well as the pre-commit hook version. Concerning the latter: would you have the opportunity to have a look at gauge-sh/tach-pre-commit#2, such that we can point the pre-commit hook to the upstream repository again? Thanks! |
airwoodix
merged commit 59bb7bc
into
qiskit-community:api-client-workspaces
15 checks passed
airwoodix
added a commit
that referenced
this pull request
Nov 25, 2024
* api_client: implement workspaces() query * Upgrade tach to 0.15.0, use 'interfaces' instead of strict mode (#201) Co-authored-by: Evan Doyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #200 , Tach released 'interfaces' in
0.15.0(gauge-sh/tach#428).This replaces 'strict' with an explicit interface within
tach.toml, and I included those changes in this PR.This means that the re-exporting through
__all__can also be removed, although I haven't made that change in this PR.