api_client: implement workspaces() query #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airwoodix
force-pushed
the
api-client-workspaces
branch
2 times, most recently
from
05478fe to
05afb41
Compare
airwoodix
force-pushed
the
api-client-workspaces
branch
from
05afb41 to
86590b3
Compare
wilfried-huss
approved these changes
Nov 21, 2024
Co-authored-by: Etienne Wodey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following up on #198, this patch implements a client for the
GET /workspacesendpoint on the portal API.The new
PortalClientis used in theAQTProviderimplementation to query the data for remote workspaces in theBackendTable. The related code in the adapted on a least-effort basis. In particular, since there's no dedicated client for the direct-access API, theAQTDirectAccessResourceimplementation still uses the ad-hoc factory for a barehttpx.Client.The documentation gets a new section in the reference chapter, with documentation for the new
PortalClientand related types, including usage examples.Details and comments
api_clientsub-package currently re-exports all its public symbols at its root, as an effort to enabletach's strict mode at low cost. This can be improved on once [0.15.0] Move from 'strict mode' to explicit interfaces gauge-sh/tach#428 is released.