Switching to stylized icons #4253
Conversation
This will look like this: https://goo.gl/tV7duh
|
Definitely we need to change the icon theme. |
|
@sledgehammer999 we should think in the icons... The default icon theme in Windows is really ugly, awfull in Windows 10... Some icons are too small for HDPI displays (Mac OS)... |
|
Looks very nice. Fits qBittorrent perfectly. |
Agree with this. @bertyhell |
ghost
mentioned this pull request
|
I'll see if i can finish it this weekend. I first wanted to see if you guys were interested. |
|
Hey, we're about 40% done They are done by hand. |
|
ok guys Have a sneek peek here: |
|
@bertyhell Looks great indeed, well done. |
|
Sure, shouldn't be a problem |
|
@sledgehammer999 @Chocobo1 I said that before but with little success. We should pack icons in folders src/icons/theme1, src/icons/theme2... Each folder is a theme and should include all icons used in qBittorrent. By now we can ship the Oxygen theme subset but in the future we can include more themes for Windows and MacOS. The user will be able to change the theme folder in Options and graphic designers can propose new themes or new icons. |
|
Good idea. Whoever implements that can copy all the icons into the correct folders. If we do this in this PR it will break all icon references, right? |
bertyhell
changed the title
|
@bertyhell don't change your PR because of my comment. Wait for sledgehammer999. |
|
👍 |
sledgehammer999
added
the
Look and feel
|
@bertyhell Thanks for the effort. Actually I was too looking to replace everything with flat icons from icon fonts. But never got around to it. Can you post a screenshot on how your current progress looks in the app? Unless you aren't able to compile qbt. I don't know if you have covered the "completed" icon. If not, I suggest having "tick" sign(in a frame) with the current color scheme. And I might have similar suggestions for other icons. It all depends on how far you have come.
PS: Let's first tackle what the icons will look like, and then worry about sources/scripts/license compliance etc. No. I don't want theming support (or something like that). Plus it will bloat the binary. |
|
I can try to build it on Friday. How easy is that on windows? Is there a step-by-step i can follow? The screenshot i posted is our current progress. We hope to finish all the icons in the oxigen folder on Friday. The other icons will take some more time. As for the license we're using font awesome as a base for these with some self made icons were needed. So we should be good on that front. |
|
I can test & review this PR at night. |
|
I'll have to generate and commit the pngs first. I can do that on friday. |
|
Ok. I can also probably do a test build in a few hours. I'll post screenshot. |
Oops. Now I saw that. Then I'll wait. |
|
I do NOT want this grayish Windows-10-like shit in qBitTorrent. If you're gonna add it, PLEASE make it optional. |
|
I almost never look at my torrent client, because it's basically a background application. I wonder why you need to constantly gaze at what's inside of it. OK, speaking of this 2D design. The first two icons contain too much antialiasing and they basically look dirty. If we're going this path I want them to be 100% monotone.
If possible please do not delete old icons from the source distribution and make an icon pack selectable via a ./configure option. |
|
Thank you for your comment. I just hope that there won't be a situation when new additional actions are introduced in QBitTorrent and the old icons set becomes incomplete thus people won't be able to use it successfully. |
… to png Check readme for more information on how to convert the icons to png src/icons/oxygen/build-icons/readme.md
Having the original svg's in the repo + a way to easaly generate the png's is quite useful in my opinion. That way other people can tweak the icons without having the manually recreate them every time.
Yes, those are still required. To run that grunt task you need node.js. The node package manager will install a bunch of files in node_modules to get all the required files for doing the svg to png conversion. You don't want to see those node_module files in your git status. Having the png ignored as well is required, since someone generating the png files doesn't want to check them in there (src/icons/skin/build-icons/icons/), but rather move them to the "drop in replace" location (src/icons/oxygen/). |
Could you explain this, please? Why would one need a png file to edit its source, the svg one? |
Oh, sorry, i had misread your comment. Yeah, you're right, we can drop all those once we switch to svg assets. 👍 |
|
Thanks, @bertyhell. |
|
@bertyhell the pngs currently need to be inside |
|
You can choose what ever. |
|
OK. I'll do the merge tomorrow when I have a non-sleepy head. |
Yeah, tried that, it's awfully slow if you need to resize/load them on-the-fly, so there might need some mechanisms caching them. |
|
Thx for the great effort. Be around if users start complaining :p |
@Chocobo1, could you give any numbers, please? Plasma uses svg icons for many years and I can't see any signs of a slowness. |
No benchmark for that, I just tried to load svgs in place of pngs; when opening a dialog/window, it took about 1~2 secs to pop up (normally would be instant). |
he did it, he really did it |
github.com now has a feature for this: https://github.com/blog/2141-squash-your-commits |
|
Am I getting something wrong here? What do I have to do to get these icons? They look amazing but I still have the ugly ones. I'm using qBittorrent v3.3.14 64-bit for Windows, which I got from here Are they coming with 3.4? |
|
These icons will be released with version 3.4.0, |
|
I see. Waiting for that then! |
|
Nice, I'll wait for the beta, just to help with bug reports, and if it takes too long I'll go with these. Thanks! :D EDIT: Beta stalled as expected, I'll try these builds :) |
|
Those icons doesn't look good on Windows 10. Quite dark and colorless. Would be nicer to be lightened. Squarish icons also overloading table of tasks. |
|
I love them. |
|
@regs01 I agree. The icons could be a little bit brighter. They seem somewhat dull. It's definitely an improvement over the old icons but they just need to "pop" a bit more. Especially the red delete button. The "red" color is so dull that you almost can't tell it's red. Everything needs to be a few shades brighter, especially the red, yellow and orange icons. It doesn't have to be Material Design bright. Just bright enough to not be dull. |
|
Blue icons on high contrast theme win 10 🙊
|
This will look like this:
If you like these, we can change all of them.
Were using font awesome as a basis for these icons. Let me know what you think.