Made normalization switchable (vst/rlog) #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he report explanation; can now use vst if rlog is skipped, will otherwise use rlog
WackerO
changed the title
ggabernet
reviewed
Mar 17, 2022
There was a problem hiding this comment.
Hi @WackerO,
the PR looks good, I would just not call the param --skip_rlog any more but rather --use_rlog and when this is provided then it uses rlog instead of vst as you already implemented. It is easier to understand in my opinion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to contributing to qbic-pipelines!
This PR is in regard to issue #99 as a follow-up. It changes the DE analysis and report to use a vst normalization if rlog is skipped; otherwise, the rlog normalization is used.
PR checklist
nextflow run . -profile test,docker).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/qbic-pipelines/rnadeseq/tree/master/.github/CONTRIBUTING.md