Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support locale option for formattedValue & set locale numFmtMap #1525

Merged
merged 1 commit into from
May 6, 2023

Conversation

fudali113
Copy link
Contributor

PR Details

Description

support locale option for formattedValue

Related Issue

#1199

Motivation and Context

#1199

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 20, 2023
@fudali113 fudali113 force-pushed the support-locale-formatted-value branch 2 times, most recently from 648772b to 1636069 Compare April 21, 2023 10:10
@xuri xuri added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2023
@xuri
Copy link
Member

xuri commented Apr 22, 2023

Thanks for your pull request. This PR contains a lot of code and I need some time to review.

@fudali113 fudali113 force-pushed the support-locale-formatted-value branch from 1636069 to 788b7ea Compare April 23, 2023 02:54
@fudali113 fudali113 force-pushed the support-locale-formatted-value branch 2 times, most recently from 3984b6a to ddb0f66 Compare May 6, 2023 07:06
@xuri xuri force-pushed the support-locale-formatted-value branch from ddb0f66 to 203c6e5 Compare May 6, 2023 11:52
@xuri xuri added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 6, 2023
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Merging #1525 (203c6e5) into master (bbdb83a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #1525   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          31       31           
  Lines       24453    24469   +16     
=======================================
+ Hits        24153    24169   +16     
  Misses        199      199           
  Partials      101      101           
Flag Coverage Δ
unittests 98.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
excelize.go 99.04% <ø> (ø)
cell.go 98.38% <100.00%> (+<0.01%) ⬆️
file.go 88.16% <100.00%> (+0.07%) ⬆️
numfmt.go 100.00% <100.00%> (ø)

@xuri xuri merged commit dfdd97c into qax-os:master May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants