Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support user defined numFmtId to numFmtCode mapping #1524

Closed
wants to merge 1 commit into from

Conversation

fudali113
Copy link
Contributor

@fudali113 fudali113 commented Apr 19, 2023

PR Details

Description

Add a function that allows users to customize the numFmtId to numFmtCode mapping so that users can customize the mapping according to their actual business scenarios

Related Issue

#1199

Motivation and Context

#1199

How Has This Been Tested

unit test

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 19, 2023
@xuri
Copy link
Member

xuri commented Apr 19, 2023

Thanks for your pull request. I've left some comments in the issue #1199.

@fudali113
Copy link
Contributor Author

Replace this PR with another scheme: #1525

@fudali113 fudali113 closed this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants