Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for channel-specific SEVIRI calibration #2997

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Nov 22, 2024

Prepare for channel-specific calibration (#2599) by using satpy.readers.utils.CalibrationCoefficientPicker internally to select coefficients. No changes to public interfaces. Next steps in a future PR:

  • Tests added

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (fa56be5) to head (5ab316e).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2997   +/-   ##
=======================================
  Coverage   96.08%   96.09%           
=======================================
  Files         377      377           
  Lines       55155    55231   +76     
=======================================
+ Hits        52997    53073   +76     
  Misses       2158     2158           
Flag Coverage Δ
behaviourtests 3.93% <0.00%> (-0.01%) ⬇️
unittests 96.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member Author

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

@coveralls
Copy link

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 11970487783

Details

  • 150 of 150 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 96.198%

Totals Coverage Status
Change from base Build 11936881763: 0.005%
Covered Lines: 53317
Relevant Lines: 55424

💛 - Coveralls

@sfinkens
Copy link
Member Author

Regarding the CodeScene issue about seviri_base.py being too complex: I could move the calibration parts into a separate file.

@pytroll pytroll deleted a comment from rymdulf Nov 22, 2024
@pytroll pytroll deleted a comment from rymdulf Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

2 participants