Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SEVIRI calibration more transparent to the user #2569

Open
sfinkens opened this issue Sep 8, 2023 · 3 comments
Open

Make SEVIRI calibration more transparent to the user #2569

sfinkens opened this issue Sep 8, 2023 · 3 comments
Assignees
Labels
component:readers enhancement code enhancements, features, improvements

Comments

@sfinkens
Copy link
Member

sfinkens commented Sep 8, 2023

Feature Request

Is your feature request related to a problem? Please describe.
In some situations SEVIRI users request GSICS calibration but get Nominal calibration. Reason: If GISCS coefficients are not available for a certain channel, the SEVIRI calibration handler silently falls back to nominal coefficients. For users it's hard to know which coefficient has been applied. They would have to compare both calibration methods or check the header contents.

Example: MSG3-SEVI-MSG15-0100-NA-20130302231244.078000000Z-NA.nat has GSICS coefficients only for IR_087 and IR_120.

Describe the solution you'd like

  • Add dataset attributes calib_method describing the calibration method and calib_coefs specifying the applied coefficients
  • Update documentation to describe this behaviour. Also, add link to GSICS website for latest coefficients.
  • Log a warning when falling back to Nominal coefficients

Describe any changes to existing user workflow
None

Additional context
None

@sfinkens sfinkens self-assigned this Sep 8, 2023
@sfinkens sfinkens added enhancement code enhancements, features, improvements component:readers labels Sep 8, 2023
@pdebuyl
Copy link
Contributor

pdebuyl commented Sep 8, 2023

Question: if the user requests a specific set of calibration, shouldn't satpy raise an actual error?

@mraspaud
Copy link
Member

mraspaud commented Sep 8, 2023

Question: if the user requests a specific set of calibration, shouldn't satpy raise an actual error?

I agree actually... (that this should be raising an error)

@sfinkens
Copy link
Member Author

Good point! Then we would need an additional reader kwarg to allow mixing of coefficients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
Status: No status
Development

No branches or pull requests

3 participants