-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change start_time
and end_time
handling in combine_metadata
#2737
Merged
Merged
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8319b4f
Change time attribute averaging to min/max for start/end times
lahtinep 782ac68
Change time attribute averaging to min/max for start/end times
lahtinep cf98aa2
Allow None as time value
lahtinep ab90428
Update combine_metadata docstring
lahtinep cbe2549
Merge branch 'main' into min-max-dataset-times
lahtinep 942be9c
Do not include top-level non-time objects in shared_info as times
lahtinep db2bf31
Remove combine_times kwarg from multiscene.stack and default to its d…
lahtinep e0fe845
Remove obsolete private function
lahtinep 6e1342f
Remove unnecessary setting of start/end time attributes
lahtinep 13168cf
Remove assertions that don't hold when not loading an actual image
lahtinep f7e7570
Combine also values of 'time_parameters' dictionary items
lahtinep 4e85a8f
Separate value combination to a new function
lahtinep 91dbc8e
Reword docstring of combine_metadata() to include time_parameters dict
lahtinep 9d5665c
Clarify combine_metadata() docstring
lahtinep 83f6bc8
Update satpy/dataset/metadata.py
djhoese b68920f
Remove douple handling of start/end times and time parameters
lahtinep d1c33a1
Use datetimes when testing times
lahtinep 3e050b0
Refactor to remove unnecessary return
lahtinep aee140a
Update satpy/dataset/metadata.py
pnuu 52b2d41
Update satpy/dataset/metadata.py
pnuu b8a47a9
Add a warning when trying to use removed 'average_times' kwarg
lahtinep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a deprecation path, where a warning is raised if code passes
average_times
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure any people are actually using this, but given that it exists means we thought someone might want to control it so I agree that it should be documented at the very least. A specific deprecation warning would be nice to have.
The changes in the multiscene code are also backwards incompatible, but very very unlikely to be used by anyone except maybe Adam and Ernst. If I remember correctly the default behavior is preserved and was changed when the related kwarg was added to the multiscene stacking function. So my vote is no deprecation warning on the multiscene stuff, but warning on the metadata.py
average_times
would be nice to have.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll see about the deprecation warning, hopefully tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a
UserWarning
if someone tries to use theaverage_times
kwarg.