Change start_time and end_time handling in combine_metadata
#2737
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 7 findings(s) ✅
- Affected Hotspots: 2 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
✅ Improving Code Health:
- Lines of Code in a Single File init.py 🔥
- Lines of Code in a Single File test_composites.py 🔥
- Excess Number of Function Arguments test_blend.py: TestBlendFuncs.test_blend_two_scenes_using_stack_weighted
- Complex Conditional metadata.py: _combine_shared_info
- Complex Conditional _blend_funcs.py: _combine_stacked_attrs
- Complex Conditional _blend_funcs.py: _get_combined_start_end_times
- Code Duplication test_file_handlers.py
Annotations
Check notice on line 1 in satpy/composites/__init__.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1261 to 1255, improve code health by reducing it to 600. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 100 in satpy/dataset/metadata.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
_combine_shared_info no longer has a complex conditional
Check notice on line 1 in satpy/tests/test_composites.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1484 to 1480, improve code health by reducing it to 600. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 1 in satpy/tests/test_dataset.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 717 to 760, improve code health by reducing it to 600. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 1 in satpy/tests/test_dataset.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Low Cohesion
The number of different responsibilities increases from 51 to 54, threshold = 4. Cohesion is calculated using the LCOM4 metric. Low cohesion means that the module/class has multiple unrelated responsibilities, doing too many things and breaking the Single Responsibility Principle.
Check notice on line 138 in satpy/multiscene/_blend_funcs.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
_combine_stacked_attrs no longer has a complex conditional
Check notice on line 138 in satpy/multiscene/_blend_funcs.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
_get_combined_start_end_times no longer has a complex conditional
Check notice on line 278 in satpy/tests/multiscene_tests/test_blend.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Excess Number of Function Arguments
TestBlendFuncs.test_blend_two_scenes_using_stack_weighted decreases from 7 to 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 1 in satpy/tests/test_file_handlers.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Code Duplication
The module no longer contains too many functions with similar structure