Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SPMD logging to indicate that we're using virtual device #8501

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Remove SPMD logging to indicate that we're using virtual device #8501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions torch_xla/csrc/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,6 @@ bool ShouldUseVirtualDevice() {
bool use_virtual_device =
runtime::sys_util::GetEnvBool("XLA_USE_SPMD", false) ||
runtime::sys_util::GetEnvBool("XLA_AUTO_SPMD", false);
if (use_virtual_device) {
TF_LOG(INFO) << "Using SPMD virtual device optimization";
}
return use_virtual_device;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is reasonable for me, also wanna suggest to bring it back with cleaner log history version in the future due to its a good signal for user to notice the code has started running

}

Expand Down
Loading