Remove SPMD logging to indicate that we're using virtual device #8501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShouldUseVirtualDevice is called pretty liberally throughout ptxla code and it creates a lot of log spam
ManfeiBai
reviewed
Dec 18, 2024
| @@ -81,9 +81,6 @@ bool ShouldUseVirtualDevice() { | |||
| bool use_virtual_device = | |||
| runtime::sys_util::GetEnvBool("XLA_USE_SPMD", false) || | |||
| runtime::sys_util::GetEnvBool("XLA_AUTO_SPMD", false); | |||
| if (use_virtual_device) { | |||
| TF_LOG(INFO) << "Using SPMD virtual device optimization"; | |||
| } | |||
| return use_virtual_device; | |||
There was a problem hiding this comment.
this change is reasonable for me, also wanna suggest to bring it back with cleaner log history version in the future due to its a good signal for user to notice the code has started running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShouldUseVirtualDevice is called pretty liberally throughout ptxla code and it creates a lot of log spam