Remove unused imports after manual review #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Co-authored-by: Vasilis Vryniotis <[email protected]>
bw4sz
commented
Jan 7, 2021
You can safely remove the 2 remaining ones I'm flagging on the unresolved comment. Once this is fixed we can merge the PR. :) |
|
@bw4sz Hmm. Unfortunately I can not merge because the branch is out of date with the master branch and I don't have permissions to modify your branch. Either merge with the latest master or click the |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 21, 2021
Summary: * remove unused imports after manual review * Update torchvision/datasets/voc.py * remove two more instances Reviewed By: datumbox Differential Revision: D25954561 fbshipit-source-id: 56391cc53e8d4e636ae79ec1a5e91d49ea498661 Co-authored-by: Vasilis Vryniotis <[email protected]> Co-authored-by: Ben Weinstein <[email protected]> Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from #3226 (comment). @datumbox
This was my first week with pytorch coming from a few years of tensorflow. I try to contribute in any small way to get a feeling for the codebase. I went through and looked for unused imports using my IDE (WingPro 7) which identifies unused imports. I then searched the script to confirm, followed by a manual inspection. I intentionally used a very light hand, there were many situations where an unused import was in a commented out line, or in the 'examples' in the docstring. I choose leave those in, since this was just a small style update. In a roundabout way this is also a nice test of code coverage and unit tests to make sure pull requests are adequately evaluated. I hope it is useful.
Thanks for your work.