Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transforms.py #3226

Closed
wants to merge 1 commit into from
Closed

Update transforms.py #3226

wants to merge 1 commit into from

Conversation

bw4sz
Copy link
Contributor

@bw4sz bw4sz commented Jan 6, 2021

torch module is not used in this script. Tiny style change. Thanks for these helpful scripts.

torch module is not used in this script. Tiny change.
@facebook-github-bot
Copy link

Hi @bw4sz!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@datumbox
Copy link
Contributor

datumbox commented Jan 7, 2021

@bw4sz Thanks for reporting.

I believe there are a few other places in the code where we have unused imports. These two for example:

import torch.nn.functional as F
from torchvision.ops import misc as misc_nn_ops

Do you mind having a look to the rest of the codebase, fixing them and updating your PR? You might simplify the task by using an IDE or a static analysis tool.

@datumbox datumbox self-requested a review January 7, 2021 11:20
@bw4sz
Copy link
Contributor Author

bw4sz commented Jan 7, 2021 via email

@bw4sz
Copy link
Contributor Author

bw4sz commented Jan 7, 2021

closed in favor of #3229

@bw4sz bw4sz closed this Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants