Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing VISION_API from backward() methods and adding an ops.h #3163

Merged
merged 2 commits into from
Dec 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion torchvision/csrc/ops/deform_conv2d.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ VISION_API at::Tensor deform_conv2d(

namespace detail {

VISION_API
std::tuple<at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor>
_deform_conv2d_backward(
const at::Tensor& grad,
Expand Down
8 changes: 8 additions & 0 deletions torchvision/csrc/ops/ops.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#pragma once

#include "deform_conv2d.h"
#include "nms.h"
#include "ps_roi_align.h"
#include "ps_roi_pool.h"
#include "roi_align.h"
#include "roi_pool.h"
2 changes: 1 addition & 1 deletion torchvision/csrc/ops/ps_roi_align.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ VISION_API std::tuple<at::Tensor, at::Tensor> ps_roi_align(

namespace detail {

VISION_API at::Tensor _ps_roi_align_backward(
at::Tensor _ps_roi_align_backward(
const at::Tensor& grad,
const at::Tensor& rois,
const at::Tensor& channel_mapping,
Expand Down
2 changes: 1 addition & 1 deletion torchvision/csrc/ops/ps_roi_pool.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ VISION_API std::tuple<at::Tensor, at::Tensor> ps_roi_pool(

namespace detail {

VISION_API at::Tensor _ps_roi_pool_backward(
at::Tensor _ps_roi_pool_backward(
const at::Tensor& grad,
const at::Tensor& rois,
const at::Tensor& channel_mapping,
Expand Down
2 changes: 1 addition & 1 deletion torchvision/csrc/ops/roi_align.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ VISION_API at::Tensor roi_align(

namespace detail {

VISION_API at::Tensor _roi_align_backward(
at::Tensor _roi_align_backward(
const at::Tensor& grad,
const at::Tensor& rois,
double spatial_scale,
Expand Down
2 changes: 1 addition & 1 deletion torchvision/csrc/ops/roi_pool.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ VISION_API std::tuple<at::Tensor, at::Tensor> roi_pool(

namespace detail {

VISION_API at::Tensor _roi_pool_backward(
at::Tensor _roi_pool_backward(
const at::Tensor& grad,
const at::Tensor& rois,
const at::Tensor& argmax,
Expand Down