Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing VISION_API from backward() methods and adding an ops.h #3163

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Removing VISION_API from backward() methods and adding an ops.h #3163

merged 2 commits into from
Dec 14, 2020

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Dec 12, 2020 •
edited
Loading

Minor clean ups on the ops implementations:

  • PR Move autograd implementations on separate files. #3154 added all the backward method inside the vision::ops::detail namespace. Those methods are part of the internal API and should not be marked with VISION_API.
  • ops is missing an ops.h that conveniently adds all operator headers. images and models namespaces have similar header files, so I add one for ops as well.

@datumbox datumbox requested a review from vfdev-5 December 12, 2020 13:35
@datumbox datumbox changed the title Removing VISION_API from backward() methods and adding a ops.h Removing VISION_API from backward() methods and adding an ops.h Dec 12, 2020
@datumbox datumbox mentioned this pull request Dec 12, 2020
Closed
6 tasks
@codecov
Copy link

codecov bot commented Dec 12, 2020 •
edited
Loading

Codecov Report

Merging #3163 (f492c42) into master (45d9a30) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3163   +/-   ##
=======================================
  Coverage   72.79%   72.79%           
=======================================
  Files          98       98           
  Lines        8964     8964           
  Branches     1430     1430           
=======================================
  Hits         6525     6525           
  Misses       1992     1992           
  Partials      447      447

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45d9a30...f492c42. Read the comment docs.

fmassa
fmassa approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 4eab7a6 into pytorch:master Dec 14, 2020
@datumbox datumbox deleted the bug/remove_visionapi_backward branch December 14, 2020 09:44
facebook-github-bot pushed a commit that referenced this pull request Dec 15, 2020
@fmassa @facebook-github-bot
Removing VISION_API from backward() methods and adding an ops.h (#3163)
637ea80 
Summary:
* Removing VISION_API from backward() methods and adding a ops.h

* Fixing clang format.

Reviewed By: datumbox

Differential Revision: D25531032

fbshipit-source-id: a9241ac53196ca14647002a29c476909b50ee064
@datumbox datumbox mentioned this pull request Jan 5, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

@vfdev-5 vfdev-5 Awaiting requested review from vfdev-5

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datumbox @fmassa @facebook-github-bot