-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a warning if any clip can't be obtained from a video in VideoClips. #2513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @bryant1410! CI failure seems unrelated.
Codecov Report
@@ Coverage Diff @@
## master #2513 +/- ##
==========================================
- Coverage 72.36% 71.29% -1.07%
==========================================
Files 99 94 -5
Lines 8817 8296 -521
Branches 1385 1398 +13
==========================================
- Hits 6380 5915 -465
+ Misses 2005 1945 -60
- Partials 432 436 +4
Continue to review full report at Codecov.
|
@bryant1410 Could you add a test that hits the new warning? |
c36d937
to
ef3a61f
Compare
Done! (and rebased) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
…s. (pytorch#2513) * Add a warning if a clip can't be get from a video in VideoClips * Update torchvision/datasets/video_utils.py Co-authored-by: Philip Meier <[email protected]> * Add a test Co-authored-by: Philip Meier <[email protected]>
Fix #2510