Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning if any clip can't be obtained from a video in VideoClips. #2513

Merged
merged 3 commits into from
Nov 26, 2020

Conversation

bryant1410
Copy link
Contributor

Fix #2510

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bryant1410! CI failure seems unrelated.

torchvision/datasets/video_utils.py Outdated Show resolved Hide resolved
@bryant1410 bryant1410 changed the title Add a warning if a clip can't be get from a video in VideoClips Add a warning if any clip can't be obtained from a video in VideoClips. Jul 29, 2020
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #2513 (4f9ff20) into master (4521f6d) will decrease coverage by 1.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
- Coverage   72.36%   71.29%   -1.07%     
==========================================
  Files          99       94       -5     
  Lines        8817     8296     -521     
  Branches     1385     1398      +13     
==========================================
- Hits         6380     5915     -465     
+ Misses       2005     1945      -60     
- Partials      432      436       +4     
Impacted Files Coverage Δ
torchvision/datasets/video_utils.py 76.19% <100.00%> (-1.39%) ⬇️
torchvision/datasets/ucf101.py 27.08% <0.00%> (-62.50%) ⬇️
torchvision/ops/feature_pyramid_network.py 75.82% <0.00%> (-18.69%) ⬇️
torchvision/datasets/vision.py 47.36% <0.00%> (-16.43%) ⬇️
torchvision/models/detection/_utils.py 67.34% <0.00%> (-16.10%) ⬇️
torchvision/io/image.py 71.73% <0.00%> (-10.87%) ⬇️
torchvision/io/video.py 69.82% <0.00%> (-10.66%) ⬇️
torchvision/transforms/functional_tensor.py 64.91% <0.00%> (-8.76%) ⬇️
torchvision/datasets/utils.py 56.17% <0.00%> (-8.47%) ⬇️
torchvision/ops/deform_conv.py 66.66% <0.00%> (-5.65%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4521f6d...ef3a61f. Read the comment docs.

@pmeier
Copy link
Collaborator

pmeier commented Jul 30, 2020

@bryant1410 Could you add a test that hits the new warning?

@bryant1410
Copy link
Contributor Author

@bryant1410 Could you add a test that hits the new warning?

Done! (and rebased)

Copy link
Contributor

@bjuncek bjuncek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@datumbox datumbox merged commit 1bdda8c into pytorch:master Nov 26, 2020
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
…s. (pytorch#2513)

* Add a warning if a clip can't be get from a video in VideoClips

* Update torchvision/datasets/video_utils.py

Co-authored-by: Philip Meier <[email protected]>

* Add a test

Co-authored-by: Philip Meier <[email protected]>
@bryant1410 bryant1410 deleted the warn-no-clip-video branch May 6, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VideoClips fails silently when you don't have at least clip_length_in_frames in a video
5 participants