Add a warning if any clip can't be obtained from a video in VideoClip…

…s. (pytorch#2513) * Add a warning if a clip can't be get from a video in VideoClips * Update torchvision/datasets/video_utils.py Co-authored-by: Philip Meier <[email protected]> * Add a test Co-authored-by: Philip Meier <[email protected]>
Quansight · Dec 4, 2020 · f8890a2 · f8890a2
1 parent 6b409dc
commit f8890a2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/test/test_datasets_video_utils.py b/test/test_datasets_video_utils.py
@@ -119,6 +119,16 @@ def test_compute_clips_for_video(self):
         self.assertTrue(clips.equal(idxs))
         self.assertTrue(idxs.flatten().equal(resampled_idxs))
 
+        # case 3: frames aren't enough for a clip
+        num_frames = 32
+        orig_fps = 30
+        new_fps = 13
+        with self.assertWarns(UserWarning):
+            clips, idxs = VideoClips.compute_clips_for_video(video_pts, num_frames, num_frames,
+                                                             orig_fps, new_fps)
+        self.assertEqual(len(clips), 0)
+        self.assertEqual(len(idxs), 0)
+
 
 if __name__ == '__main__':
     unittest.main()
diff --git a/torchvision/datasets/video_utils.py b/torchvision/datasets/video_utils.py
@@ -1,5 +1,6 @@
 import bisect
 import math
+import warnings
 from fractions import Fraction
 from typing import List
 
@@ -204,6 +205,9 @@ def compute_clips_for_video(video_pts, num_frames, step, fps, frame_rate):
         )
         video_pts = video_pts[idxs]
         clips = unfold(video_pts, num_frames, step)
+        if not clips.numel():
+            warnings.warn("There aren't enough frames in the current video to get a clip for the given clip length and "
+                          "frames between clips. The video (and potentially others) will be skipped.")
         if isinstance(idxs, slice):
             idxs = [idxs] * len(clips)
         else: