Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] specs batch size refactoring #829

Merged
merged 34 commits into from
Jan 22, 2023
Merged

[Refactor] specs batch size refactoring #829

merged 34 commits into from
Jan 22, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 13, 2023

Description

Specs refactoring: enforces that specs and envs have a similar batch_size.

@matteobettini

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 13, 2023
@vmoens vmoens changed the title [Refactor] specs batch size refactoring [WIP, Refactor] specs batch size refactoring Jan 13, 2023
@vmoens vmoens added enhancement New feature or request Refactoring Refactoring of an existing feature labels Jan 13, 2023
@vmoens vmoens changed the title [WIP, Refactor] specs batch size refactoring [Refactor] specs batch size refactoring Jan 20, 2023
@vmoens vmoens marked this pull request as ready for review January 20, 2023 21:01
@vmoens vmoens merged commit bdf2bcd into main Jan 22, 2023
@vmoens vmoens added bc breaking backward compatibility breaking change major major refactoring in the code base labels Jan 22, 2023
@vmoens vmoens deleted the composite_batch branch January 22, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bc breaking backward compatibility breaking change CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request major major refactoring in the code base Refactoring Refactoring of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants