Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix zero-ing from specs in RewardSum #860

Merged
merged 2 commits into from
Jan 24, 2023
Merged

[BugFix] Fix zero-ing from specs in RewardSum #860

merged 2 commits into from
Jan 24, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 24, 2023 •
edited
Loading

Description

Fixes a bug where RewardSum creates buffers with the parent batch_size, which we don't want since #829

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 24, 2023
@vmoens vmoens added the bug Something isn't working label Jan 24, 2023
@vmoens vmoens merged commit 3b64392 into main Jan 24, 2023
@vmoens vmoens deleted the bugfix_zeroingepisodereward branch July 11, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot