Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 to TorchData CICD #1199

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions .github/workflows/build_wheels_aarch64_linux.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: Build AARCH64 Linux Wheels

on:
pull_request:
push:
branches:
- nightly
workflow_dispatch:

jobs:
generate-matrix:
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
with:
package-type: wheel
os: linux-aarch64
test-infra-repository: pytorch/test-infra
test-infra-ref: main
with-cuda: disable
build:
needs: generate-matrix
strategy:
fail-fast: false
matrix:
include:
- repository: pytorch/data
pre-script: packaging/pre_build_script_linux.sh
post-script: packaging/post_build_script_linux.sh
smoke-test-script: test/smoke_test/smoke_test.py
package-name: torchdata
name: ${{ matrix.repository }}
uses: pytorch/test-infra/.github/workflows/build_wheels_linux.yml@main
with:
repository: ${{ matrix.repository }}
ref: ""
test-infra-repository: pytorch/test-infra
test-infra-ref: main
build-matrix: ${{ needs.generate-matrix.outputs.matrix }}
pre-script: ${{ matrix.pre-script }}
post-script: ${{ matrix.post-script }}
smoke-test-script: ${{ matrix.smoke-test-script }}
package-name: ${{ matrix.package-name }}
env-var-script: packaging/env-var-script.txt
architecture: aarch64
setup-miniconda: false
# Using "development" as trigger event so these binaries are not uploaded to official channels yet
trigger-event: development
secrets:
AWS_PYTORCH_UPLOADER_ACCESS_KEY_ID: ${{ secrets.PYTORCH_BINARY_AWS_ACCESS_KEY_ID }}
AWS_PYTORCH_UPLOADER_SECRET_ACCESS_KEY: ${{ secrets.PYTORCH_BINARY_AWS_SECRET_ACCESS_KEY }}
49 changes: 0 additions & 49 deletions .github/workflows/domain_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,55 +10,6 @@ on:
- gh/*/*/base

jobs:
torchvision:
if: ${{ github.repository_owner == 'pytorch' }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os:
- macos-latest
- ubuntu-latest
- windows-latest
python-version:
- 3.8
- 3.9
steps:
- name: Setup Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

- name: Install torch and torchvision from nightlies
run: |
pip install numpy networkx
pip install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cpu

- name: Check out torchdata repository
uses: actions/checkout@v3

- name: Install torchdata
run: |
pip install -r requirements.txt
pip install .

- name: Install test requirements
run: pip install pytest pytest-mock scipy iopath pycocotools h5py

- name: Extract torchvision ref
id: torchvision
run: echo "ref=$(python -c 'import torchvision; print(torchvision.version.git_version)')" >> $GITHUB_OUTPUT

- name: Check out torchvision repository
uses: actions/checkout@v3
with:
repository: pytorch/vision
ref: ${{ steps.torchvision.outputs.ref }}
path: vision

- name: Run torchvision builtin datasets tests
run: pytest --no-header -v vision/test/test_prototype_datasets_builtin.py

torchtext:
if: ${{ github.repository_owner == 'pytorch' }}
runs-on: ${{ matrix.os }}
Expand Down
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@
[**What are DataPipes?**](#what-are-datapipes) | [**Beta Usage and Feedback**](#beta-usage-and-feedback) |
[**Contributing**](#contributing) | [**Future Plans**](#future-plans)

**:warning: As of July 2023, we have paused active development on TorchData and have paused new releases. We have learnt a lot from building it and hearing from users, but also believe we need to re-evaluate the technical design and approach given how much the industry has changed since we began the project. During the rest of 2023 we will be re-evaluating our plans in this space. Please reach out if you suggestions or comments (please use [#1196](https://github.com/pytorch/data/issues/1196) for feedback).**
**:warning: As of July 2023, we have paused active development on TorchData and have paused new releases. We have learnt
a lot from building it and hearing from users, but also believe we need to re-evaluate the technical design and approach
given how much the industry has changed since we began the project. During the rest of 2023 we will be re-evaluating our
plans in this space. Please reach out if you suggestions or comments (please use
[#1196](https://github.com/pytorch/data/issues/1196) for feedback).**

`torchdata` is a library of common modular data loading primitives for easily constructing flexible and performant data
pipelines.
Expand Down
8 changes: 5 additions & 3 deletions packaging/post_build_script_linux.sh
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
#!/bin/bash
set -ex

cpu_arch=`uname -m`

pip3 install auditwheel pkginfo

for pkg in dist/torchdata*.whl; do
echo "PkgInfo of $pkg:"
pkginfo $pkg

auditwheel repair $pkg --plat manylinux2014_x86_64 -w wheelhouse
auditwheel repair $pkg --plat manylinux2014_${cpu_arch} -w wheelhouse

pkg_name=`basename ${pkg%-linux_x86_64.whl}`
auditwheel show wheelhouse/${pkg_name}-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
pkg_name=`basename ${pkg%-linux_${cpu_arch}.whl}`
auditwheel show wheelhouse/${pkg_name}-manylinux_2_17_${cpu_arch}.manylinux2014_${cpu_arch}.whl
done
Loading