-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aarch64 to TorchData CICD #1199
Conversation
@atalman Mind looking at this? Believe this should allow aarch64 TorchData build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM we can merge if CI is green
Btw the torchvision tests are expected to fail because they've dropped their use of torchdata so the only job that needs to be green is the BUILD AARCH64 You can however fix the torchvision tests if you pin to an older version https://github.com/pytorch/data/blob/main/.github/workflows/domain_ci.yml#L13 |
Since this is dropped for torchvision, do we even need the test anymore? |
yeah probably not, feel free to delete and I can retrigger CI |
idk what's going on with the linter but try running precommit and see if that unblocks https://github.com/pytorch/data/blob/main/CONTRIBUTING.md#code-style |
Looks like Prettier has an issue with "warning" section of the README.md. Wonder how that got by. Will update this PR to include Prettier's update to the README.md which should clear the lint issue. Going to wait and see if the build completes first. |
@msaroufim think we are good this time. Want to give it another try? |
Err not sure what to do here there's way too many failing tests that I'm not sure this is right to merge - wdyt @atalman ? |
7 of the 8 were |
@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
am closing this as the repo is a little, on pause. |
Please read through our contribution guide prior to
creating your pull request.
Fixes #{issue number}
Changes
false
as conda is installed from "Set linux aarch64 CI"post_build_script_linux.sh
to support different CPU arch types by finding the arch from there the script is executed.