Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 0.6.0] Batch cherry-pick #1057

Merged
merged 5 commits into from
Feb 28, 2023
Merged

[Release 0.6.0] Batch cherry-pick #1057

merged 5 commits into from
Feb 28, 2023

Conversation

NivekT and others added 5 commits February 27, 2023 20:15
Summary:
Pull Request resolved: #1050

Also fixed some wording and typos

Test Plan: Imported from OSS

Reviewed By: ejguan

Differential Revision: D43625322

Pulled By: NivekT

fbshipit-source-id: 37adee2d72fdf20c12560eb2134ef93749ac0293
Summary:
As mentioned in #256 it would be useful to have this in all dp that use a `key_fn`.

### Changes

- Add keep_key option to `MapKeyZipper`
- Test for the new option
- Improve example in documentation by using sphinx doctest

Pull Request resolved: #1042

Reviewed By: ejguan

Differential Revision: D43550124

Pulled By: NivekT

fbshipit-source-id: 453418560dd586ebb9ce42dd27eb1bc86eb734d0
Summary:
Following the change in PyTorch core.

pytorch/pytorch@87e4a08

Pull Request resolved: #1051

Reviewed By: NivekT

Differential Revision: D43629811

Pulled By: ejguan

fbshipit-source-id: 9fb43b055ec5731c5854f69e9902d46764411092
Summary:
Per title

Pull Request resolved: #1053

Reviewed By: NivekT

Differential Revision: D43622310

Pulled By: ejguan

fbshipit-source-id: e1aa3c8f507bec0b5b87c1b4293ae9f6ce277436
Summary: Pull Request resolved: #1011

Test Plan: Imported from OSS

Reviewed By: mingyuzh, ejguan

Differential Revision: D43251818

Pulled By: NivekT

fbshipit-source-id: 5c34e1a71438308366b473c5d4d075a8158088f1
@NivekT NivekT requested a review from ejguan February 28, 2023 01:18
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2023
@NivekT NivekT mentioned this pull request Feb 28, 2023
10 tasks
@ejguan ejguan merged commit b57545f into release/0.6 Feb 28, 2023
@andrewkho andrewkho deleted the R0.6BatchCherryPick branch September 26, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants