Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add round robin sharding documentation #1050

Closed
wants to merge 2 commits into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Feb 25, 2023

Stack from ghstack:

Also fixed some wording and typos

Differential Revision: D43625322

NivekT added a commit that referenced this pull request Feb 25, 2023
ghstack-source-id: 6f3953c83898f52ce74df164a5386f41abb6b14a
Pull Request resolved: #1050
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 25, 2023
@NivekT NivekT added the documentation Improvements or additions to documentation label Feb 25, 2023
@NivekT NivekT requested a review from ejguan February 25, 2023 00:29
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome. Thank you so much. Let's cherrypick it before the final branch cut.

docs/source/dataloader2.rst Outdated Show resolved Hide resolved
docs/source/reading_service.rst Show resolved Hide resolved
docs/source/reading_service.rst Outdated Show resolved Hide resolved
Also fixed some wording and typos

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Feb 27, 2023
ghstack-source-id: e7e39100a7cfda69c546929e7fe31dcde92273ed
Pull Request resolved: #1050
@NivekT
Copy link
Contributor Author

NivekT commented Feb 27, 2023

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NivekT NivekT mentioned this pull request Feb 27, 2023
10 tasks
@ejguan ejguan added this to the 0.6.0 milestone Feb 27, 2023
@facebook-github-bot
Copy link
Contributor

@NivekT merged this pull request in f4cf810.

NivekT added a commit that referenced this pull request Feb 28, 2023
Summary:
Pull Request resolved: #1050

Also fixed some wording and typos

Test Plan: Imported from OSS

Reviewed By: ejguan

Differential Revision: D43625322

Pulled By: NivekT

fbshipit-source-id: 37adee2d72fdf20c12560eb2134ef93749ac0293
ejguan pushed a commit that referenced this pull request Feb 28, 2023
Summary:
Pull Request resolved: #1050

Also fixed some wording and typos

Test Plan: Imported from OSS

Reviewed By: ejguan

Differential Revision: D43625322

Pulled By: NivekT

fbshipit-source-id: 37adee2d72fdf20c12560eb2134ef93749ac0293
@facebook-github-bot facebook-github-bot deleted the gh/NivekT/108/head branch March 3, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants