Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skipIfRocm from soundfile.save_test test_fileobj_flac #1626

Merged
merged 1 commit into from
Jul 12, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove skipIfRocm from test_fileobj_flac in soundfile.save_test
The test was broken from the beginning and for a reason unrelated to
ROCm, but was disabled for ROCm in
#1411.
#1604
fixed the test so that we are re-enabling it.
  • Loading branch information
yangarbiter committed Jul 12, 2021
commit 6cdb9da2cf764c89b40d8651b89943b3b1021a1e
2 changes: 0 additions & 2 deletions test/torchaudio_unittest/backend/soundfile/save_test.py
Original file line number Diff line number Diff line change
@@ -11,7 +11,6 @@
get_wav_data,
load_wav,
nested_params,
skipIfRocm,
)
from .common import (
fetch_wav_subtype,
@@ -281,7 +280,6 @@ def test_fileobj_wav(self):
self._test_fileobj('wav')

@skipIfFormatNotSupported("FLAC")
@skipIfRocm
def test_fileobj_flac(self):
"""Saving audio via file-like object works"""
self._test_fileobj('flac')