Remove skipIfRocm from soundfile.save_test test_fileobj_flac #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangarbiter
force-pushed
the
fix_soundfile_test
branch
from
f8a4c48 to
261536d
Compare
yangarbiter
force-pushed
the
fix_soundfile_test
branch
from
261536d to
c90d19c
Compare
The test was broken from the beginning and for a reason unrelated to ROCm, but was disabled for ROCm in pytorch#1411. pytorch#1604 fixed the test so that we are re-enabling it.
yangarbiter
force-pushed
the
fix_soundfile_test
branch
from
c90d19c to
6cdb9da
Compare
nateanl
pushed a commit
to nateanl/audio
that referenced
this pull request
Jul 28, 2021
…rch#1626) The test was broken from the beginning and for a reason unrelated to ROCm, but was disabled for ROCm in pytorch#1411. pytorch#1604 fixed the test so that we are re-enabling it.
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the test
soundfile.save_test::TestFileObject:test_fileobj_flacto run in the Rocm stack.