Support file-like object in save func #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mthrok
force-pushed
the
file-like-obj-5
branch
6 times, most recently
from
c56217f to
64e0511
Compare
mthrok
force-pushed
the
file-like-obj-5
branch
3 times, most recently
from
6f3364f to
97db145
Compare
mthrok
changed the title
mthrok
force-pushed
the
file-like-obj-5
branch
from
97db145 to
111cdae
Compare
mthrok
force-pushed
the
file-like-obj-5
branch
from
111cdae to
ddac5d7
Compare
cpuhrsch
reviewed
Jan 15, 2021
cpuhrsch
reviewed
Jan 15, 2021
cpuhrsch
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds file object support to
savefunction.Also this PR disables TP binary cache, as it seems to cause an occasional build error.
See #1115