Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke test for sox_io fileobj #1165

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Jan 8, 2021

Add smoke test for file object support in "sox_io" backend.

See also #1115

@mthrok mthrok mentioned this pull request Jan 8, 2021
6 tasks
@mthrok mthrok force-pushed the file-like-obj-smoke-test branch 2 times, most recently from ccc8d27 to 53e2771 Compare January 15, 2021 23:34
@mthrok mthrok added this to the v0.8 milestone Jan 25, 2021
@mthrok mthrok force-pushed the file-like-obj-smoke-test branch from 53e2771 to 2e3bc3d Compare January 25, 2021 20:55
@mthrok mthrok force-pushed the file-like-obj-smoke-test branch from 2e3bc3d to cb81873 Compare January 27, 2021 19:31
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mthrok mthrok marked this pull request as ready for review January 29, 2021 16:57
@mthrok mthrok merged commit 5085aeb into pytorch:master Jan 29, 2021
@mthrok mthrok deleted the file-like-obj-smoke-test branch January 29, 2021 16:58
@mthrok
Copy link
Collaborator Author

mthrok commented Jan 29, 2021

thanks!

mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants